This is an archive of the discontinued LLVM Phabricator instance.

[NFC][CLANG] Fix nullptr dereference issue in HandleRISCVRVVVectorBitsTypeAttr()
ClosedPublic

Authored by Manna on May 30 2023, 7:13 PM.

Details

Summary

This patch uses castAs instead of getAs which will assert if the type doesn't match in HandleRISCVRVVVectorBitsTypeAttr(clang::​QualType &, clang::​ParsedAttr &, clang::​Sema &)

Diff Detail

Event Timeline

Manna created this revision.May 30 2023, 7:13 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 30 2023, 7:13 PM
Manna requested review of this revision.May 30 2023, 7:13 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 30 2023, 7:13 PM
Manna edited the summary of this revision. (Show Details)May 30 2023, 7:22 PM
Manna updated this revision to Diff 526877.May 30 2023, 8:24 PM

Rebase the patch

Manna updated this revision to Diff 526882.May 30 2023, 8:38 PM
erichkeane accepted this revision.May 31 2023, 6:36 AM
This revision is now accepted and ready to land.May 31 2023, 6:36 AM
Manna added a comment.May 31 2023, 9:43 AM

Thank you @erichkeane for reviews!