MLIR/Cuda: Add the appropriate "HINTS" on CMake find_library and mark these REQUIRED

[mehdi_amini]

Summary

The cmake logic to find cuda paths exposes some paths to search for the cuda
library, we need to propagate this through the call for find_library.
This was already done for cuSparse but not for cuda.

[stellaraccident]

This seems ok to me, but it caused me to look at the layering of the libraries and this CMake file, and it seems unfortunate to.

I wish the dialect and transforms CMake files were in the IR and Transforms directories vs being loose leaf at the top.

Also, it seems like there should be two libraries for transforms instead of monkey patching the one with optional features (Transforms, SerializationTransforms). That was, it would be clear from the targets what is depended on vs just getting link errors if the extra CMake flag were not set.

Neither blocking this patch -- just noting that this directory could use some cleanup.

[mehdi_amini]

I landed this because that'll unblock reviving the mlir-nvidia bot right now :)

We should follow up, I'd like to understand a bit more what you have in mind and how the ExecutionEngine can get these optional features in a less intrusive way maybe.

[stellaraccident]

Sure, can follow up. Generally, I think that distinct dependencies should imply distinct library targets vs having the definition of the library changed based on an optional feature flag. That way, CMake will complain if depending on something not enabled (versus just falling through to an undefined symbol that needs to be untangled for why it isn't present).

mlir/lib/Dialect/GPU/CMakeLists.txt

if(MLIR_ENABLE_CUDA_RUNNER)
   )
 
   # Add CUDA headers includes and the libcuda.so library.
   target_include_directories(obj.MLIRGPUTransforms
     PRIVATE
     ${CMAKE_CUDA_TOOLKIT_INCLUDE_DIRECTORIES}
   )
 
-  find_library(CUDA_DRIVER_LIBRARY cuda)
-
+  find_library(CUDA_DRIVER_LIBRARY cuda HINTS ${CMAKE_CUDA_IMPLICIT_LINK_DIRECTORIES} REQUIRED)
   target_link_libraries(MLIRGPUTransforms
     PRIVATE
     MLIRNVVMToLLVMIRTranslation
     ${CUDA_DRIVER_LIBRARY}
   )
 
 endif()
 

mlir/lib/ExecutionEngine/CMakeLists.txt

if(MLIR_ENABLE_CUDA_RUNNER)
     if (CMAKE_CUDA_COMPILER)
       enable_language(CUDA)
     else()
       message(SEND_ERROR
         "Building the mlir cuda runner requires a working CUDA install")
     endif()
 
     # We need the libcuda.so library.
-    find_library(CUDA_RUNTIME_LIBRARY cuda)
+    find_library(CUDA_RUNTIME_LIBRARY cuda HINTS ${CMAKE_CUDA_IMPLICIT_LINK_DIRECTORIES} REQUIRED)
 
     # We need the libcusparse.so library.
-    find_library(CUDA_CUSPARSE_LIBRARY cusparse HINTS ${CMAKE_CUDA_IMPLICIT_LINK_DIRECTORIES})
+    find_library(CUDA_CUSPARSE_LIBRARY cusparse HINTS ${CMAKE_CUDA_IMPLICIT_LINK_DIRECTORIES} REQUIRED)
 
     add_mlir_library(mlir_cuda_runtime
       SHARED
       CudaRuntimeWrappers.cpp
 
       EXCLUDE_FROM_LIBMLIR
     )
     set_property(TARGET mlir_cuda_runtime PROPERTY CXX_STANDARD 14)