Add some of the missing libm rounding intrinsics to the LLVM dialect:
- llvm.rint
- llvm.nearbyint
- llvm.lround
- llvm.llround
- llvm.lrint
- llvm.llrint
Signed-off-by: Lukas Sommer <lukas.sommer@codeplay.com>
Paths
| Differential D151558
[mlir][llvm] Add rounding intrinsics ClosedPublic Authored by LukasSommerTu on May 26 2023, 6:04 AM.
Details Summary Add some of the missing libm rounding intrinsics to the LLVM dialect:
Signed-off-by: Lukas Sommer <lukas.sommer@codeplay.com>
Diff Detail
Event TimelineThis revision is now accepted and ready to land.May 26 2023, 7:07 AM Comment Actions Thanks, LGTM modulo some nit comments!
Closed by commit rG196d89740c5e: [mlir][llvm] Add rounding intrinsics (authored by LukasSommerTu, committed by zero9178). · Explain WhyMay 29 2023, 9:12 AM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 526450 mlir/include/mlir/Dialect/LLVMIR/LLVMIntrinsicOps.td
mlir/test/Target/LLVMIR/Import/intrinsic.ll
mlir/test/Target/LLVMIR/llvmir-intrinsics.mlir
|
nit: I know I did not do it consistently myself but can you postfix the intrinsic names with Op, e.g.:
LLVM_RIntOp
LLVM_NearbyIntOp
etc?