Page MenuHomePhabricator

LukasSommerTu (Lukas Sommer)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 2 2018, 7:15 AM (137 w, 2 d)

Recent Activity

Feb 12 2021

LukasSommerTu updated the diff for D95373: Replace vector intrinsics with call to vector library.

@spatel, @david-arm: I integrated your proposed changes/updates and updated the patch. Local tests run fine, so it should be ready for committing from my side.

Feb 12 2021, 9:02 AM · Restricted Project
LukasSommerTu added a comment to D95373: Replace vector intrinsics with call to vector library.

@spatel, @david-arm: Thanks for the update, I will integrate your proposed changes and update the patch after running some tests locally.

Feb 12 2021, 7:09 AM · Restricted Project

Feb 11 2021

LukasSommerTu added a comment to D95373: Replace vector intrinsics with call to vector library.

I reproduced the cause of the failure in the build-bot locally, fixed the bug and successfully ran the tests locally, so if you do not have any additional things that I should change, you could try again. Thanks!

Feb 11 2021, 10:08 AM · Restricted Project

Feb 8 2021

LukasSommerTu added a comment to D95373: Replace vector intrinsics with call to vector library.

@LukasSommerTu are you also looking into unifying/removing the code in SLPVectorizer/LV to create library calls?

Feb 8 2021, 9:39 AM · Restricted Project
LukasSommerTu updated the diff for D95373: Replace vector intrinsics with call to vector library.

I've found the reason for the build-bot failure, I had overlooked that codegen passes are currently pinned to the legacy PM in opt. I fixed this and also addressed @fhahn's inline comments (thanks for the feedback!).

Feb 8 2021, 9:24 AM · Restricted Project

Feb 5 2021

LukasSommerTu added a comment to D95373: Replace vector intrinsics with call to vector library.

The failure also seems to happen with X86 builds, so I suspect some connections to changes to the new PassManager, as the pass is not recognized at all. I will check that in detail and also make sure that the test works correctly, if the X86 target is not built.

Feb 5 2021, 2:34 PM · Restricted Project
LukasSommerTu added a comment to D95373: Replace vector intrinsics with call to vector library.

@spatel: I got notified about some build-bot failures, so maybe it's better to revert the commit and I will check for the cause of the build-bot failures.

Feb 5 2021, 11:51 AM · Restricted Project

Feb 4 2021

LukasSommerTu updated the diff for D95373: Replace vector intrinsics with call to vector library.

@spatel: Thanks for your quick feedback, I've addressed your comments and updated the patch.

Feb 4 2021, 9:25 AM · Restricted Project
LukasSommerTu updated the diff for D95373: Replace vector intrinsics with call to vector library.

Thanks @spatel for the detailed review!

Feb 4 2021, 7:06 AM · Restricted Project

Feb 1 2021

LukasSommerTu updated the diff for D95373: Replace vector intrinsics with call to vector library.

I've updated the implementation to have this pass as an IR codegen pass.

Feb 1 2021, 8:49 AM · Restricted Project
LukasSommerTu updated the diff for D95373: Replace vector intrinsics with call to vector library.

I've updated the implementation to have this pass as an IR codegen pass.

Feb 1 2021, 8:04 AM · Restricted Project

Jan 27 2021

LukasSommerTu added a comment to D95373: Replace vector intrinsics with call to vector library.

Thanks to everyone for your feedback so far!

Jan 27 2021, 8:39 AM · Restricted Project

Jan 25 2021

LukasSommerTu added a comment to D95373: Replace vector intrinsics with call to vector library.

@lebedev.ri: Thanks for your feedback!

My reasoning to implement this as an IR pass was that the replacement for the scalar version of the intrinsics is also happening as part of the middle-end, so it made sense to me to implement this in a similar location and use similar mechansisms.

Hm, it does? That seems quite surprising to me.

Jan 25 2021, 1:29 PM · Restricted Project
LukasSommerTu added a comment to D95373: Replace vector intrinsics with call to vector library.

@lebedev.ri: Thanks for your feedback!

Jan 25 2021, 10:03 AM · Restricted Project
LukasSommerTu added a comment to D95373: Replace vector intrinsics with call to vector library.

What's the intended use-case of this pass?

Jan 25 2021, 9:31 AM · Restricted Project
LukasSommerTu requested review of D95373: Replace vector intrinsics with call to vector library.
Jan 25 2021, 9:22 AM · Restricted Project

Jun 2 2020

LukasSommerTu added a comment to D80439: Replace separator in OpenMP variant name mangling..

@jdoerfert: Can you please commit for me, I do not have commit access. Thanks!

Jun 2 2020, 11:58 PM · Restricted Project, Restricted Project
LukasSommerTu updated the diff for D80439: Replace separator in OpenMP variant name mangling..

Added a small test checking for functions with the correctly mangled name.

Jun 2 2020, 9:19 AM · Restricted Project, Restricted Project
LukasSommerTu added a comment to D80439: Replace separator in OpenMP variant name mangling..

@jdoerfert: I've added a test. I kept it focused on the variants for NVPTX architecture (mangling is currently the same for all archs), let me know if that was what you had in mind.

Jun 2 2020, 9:19 AM · Restricted Project, Restricted Project

May 22 2020

LukasSommerTu created D80439: Replace separator in OpenMP variant name mangling..
May 22 2020, 6:57 AM · Restricted Project, Restricted Project

Apr 7 2020

LukasSommerTu added a comment to D77643: Keep output file after successful execution of mlir-opt.

@mehdi_amini: I do not have commit access, could you please commit the revision for me?

Apr 7 2020, 12:31 PM · Restricted Project
LukasSommerTu updated the summary of D77643: Keep output file after successful execution of mlir-opt.
Apr 7 2020, 12:31 PM · Restricted Project
LukasSommerTu added a comment to D77643: Keep output file after successful execution of mlir-opt.

I think it would make sense to propagate the changes to mlir-opt as well.

Apr 7 2020, 9:44 AM · Restricted Project
LukasSommerTu added a comment to D77643: Keep output file after successful execution of mlir-opt.

In the current design not. MlirOptMain does not receive the file itself, but rather an output stream, so it cannot manage the file.

Apr 7 2020, 7:00 AM · Restricted Project
LukasSommerTu created D77643: Keep output file after successful execution of mlir-opt.
Apr 7 2020, 5:55 AM · Restricted Project