This is an archive of the discontinued LLVM Phabricator instance.

Adopt Properties in builtin dialect
ClosedPublic

Authored by mehdi_amini on May 25 2023, 2:01 AM.

Details

Summary

This was missed when the other dialects adopted it.

Diff Detail

Event Timeline

mehdi_amini created this revision.May 25 2023, 2:01 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 25 2023, 2:01 AM
mehdi_amini requested review of this revision.May 25 2023, 2:01 AM
mehdi_amini edited the summary of this revision. (Show Details)Jun 1 2023, 11:45 AM

I think we can just land this as-is, @rriddle ?

rriddle accepted this revision.Jun 4 2023, 11:43 PM
This revision is now accepted and ready to land.Jun 4 2023, 11:43 PM
This revision was landed with ongoing or failed builds.Jun 5 2023, 1:27 AM
This revision was automatically updated to reflect the committed changes.
akuegel added a subscriber: akuegel.Jun 5 2023, 2:32 AM

Adding the header include #include "mlir/Bytecode/BytecodeOpInterface.h" creates a dependency cycle between "BytecodeOpInterface" and "IR" in bazel build. I wonder how CMake handles this.

Adding the header include #include "mlir/Bytecode/BytecodeOpInterface.h" creates a dependency cycle between "BytecodeOpInterface" and "IR" in bazel build. I wonder how CMake handles this.

CMake does not track header dependencies.