This is an archive of the discontinued LLVM Phabricator instance.

Differential D151405

[MLIR][sparse][GPU] fixing windows build break caused by D151014
ClosedPublic

Authored by K-Wu on May 24 2023, 9:05 PM.

Details

Reviewers
bondhugula
ThomasRaoux
nicolasvasilache
herhut
NathanielMcVicar
aartbik
Commits
rG810c7410b5f6: [MLIR][sparse][GPU] fixing windows build break caused by D151014

Diff Detail

Event Timeline

K-Wu created this revision.May 24 2023, 9:05 PM
Herald added a reviewer: bondhugula. · View Herald TranscriptMay 24 2023, 9:05 PM
Herald added a reviewer: ThomasRaoux. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: bviyer, Moerafaat, bzcheeseman and 21 others. · View Herald Transcript
K-Wu requested review of this revision.May 24 2023, 9:05 PM
Herald added a reviewer: nicolasvasilache. · View Herald TranscriptMay 24 2023, 9:05 PM
Herald added a reviewer: herhut. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
K-Wu updated this revision to Diff 525432.May 24 2023, 9:15 PM

fixing compile error

K-Wu added a reviewer: NathanielMcVicar.May 24 2023, 9:17 PM
K-Wu added a reviewer: aartbik.
K-Wu mentioned this in D151014: [mlir] [gpu] [sparse] refined SparseHandle type.
K-Wu added a subscriber: NathanielMcVicar.
K-Wu updated this revision to Diff 525433.May 24 2023, 9:27 PM

fixing compile error

Harbormaster completed remote builds in B234398: Diff 525433.May 24 2023, 9:41 PM
aartbik accepted this revision.May 25 2023, 9:46 AM
aartbik added inline comments.
mlir/lib/Dialect/GPU/IR/GPUDialect.cpp
176

I think you can omit the return after the unreachable

This revision is now accepted and ready to land.May 25 2023, 9:46 AM
Closed by commit rG810c7410b5f6: [MLIR][sparse][GPU] fixing windows build break caused by D151014 (authored by K-Wu). · Explain WhyMay 25 2023, 10:13 AM
This revision was automatically updated to reflect the committed changes.
K-Wu added a commit: rG810c7410b5f6: [MLIR][sparse][GPU] fixing windows build break caused by D151014.

Revision Contents

PathSize
mlir/
lib/
Dialect/
GPU/
IR/
1 line

Diff 525430

mlir/lib/Dialect/GPU/IR/GPUDialect.cpp

Show First 20 Lines • Show All 166 Lines • ▼ Show 20 Lines case SparseHandleKind::Env:
return "sparse.env_handle"; return "sparse.env_handle";
case SparseHandleKind::DnVec: case SparseHandleKind::DnVec:
return "sparse.dnvec_handle"; return "sparse.dnvec_handle";
case SparseHandleKind::DnMat: case SparseHandleKind::DnMat:
return "sparse.dnmat_handle"; return "sparse.dnmat_handle";
case SparseHandleKind::SpMat: case SparseHandleKind::SpMat:
return "sparse.spmat_handle"; return "sparse.spmat_handle";
} }
LLVM_UNREACHABLE_OPERATION("unknown sparse handle kind");
} }
aartbikUnsubmitted
Not Done
ReplyInline Actions

I think you can omit the return after the unreachable

aartbik: I think you can omit the return after the unreachable
Type GPUDialect::parseType(DialectAsmParser &parser) const { Type GPUDialect::parseType(DialectAsmParser &parser) const {
// Parse the main keyword for the type. // Parse the main keyword for the type.
StringRef keyword; StringRef keyword;
if (parser.parseKeyword(&keyword)) if (parser.parseKeyword(&keyword))
return Type(); return Type();
MLIRContext *context = getContext(); MLIRContext *context = getContext();
▲ Show 20 Lines • Show All 1,603 Lines • Show Last 20 Lines