Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

Differential D151305

[JITLink][AArch64] Implement R_AARCH64_ADR_PREL_LO21
ClosedPublic
Actions

Authored by jobnoorman on May 24 2023, 1:18 AM.

Details

Reviewers
lhames
sgraenitz
Commits
rGe96763894760: [JITLink][AArch64] Implement R_AARCH64_ADR_PREL_LO21
Summary

This relocation is used for the 21-bit immediate in ADR instructions.

Diff Detail

Event Timeline

jobnoorman created this revision.May 24 2023, 1:18 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 24 2023, 1:18 AM
Herald added subscribers: asb, pmatos, hiraditya, kristof.beyls. · View Herald Transcript
jobnoorman requested review of this revision.May 24 2023, 1:18 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 24 2023, 1:18 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
jobnoorman mentioned this in D147544: [BOLT] Move from RuntimeDyld to JITLink.May 24 2023, 1:22 AM
jobnoorman added a child revision: D147544: [BOLT] Move from RuntimeDyld to JITLink.
Harbormaster completed remote builds in B234115: Diff 525056.May 24 2023, 2:14 AM
jobnoorman updated this revision to Diff 525080.May 24 2023, 2:41 AM

Fix typo

Harbormaster completed remote builds in B234136: Diff 525080.May 24 2023, 3:14 AM
jobnoorman added a comment.May 31 2023, 2:03 AM

Friendly ping.

jobnoorman added a reviewer: sgraenitz.Jun 6 2023, 8:45 AM
lhames accepted this revision.Jun 7 2023, 11:22 AM

LGTM. Thanks @jobnoorman!

This revision is now accepted and ready to land.Jun 7 2023, 11:22 AM
Closed by commit rGe96763894760: [JITLink][AArch64] Implement R_AARCH64_ADR_PREL_LO21 (authored by jobnoorman). · Explain WhyJun 9 2023, 3:00 AM
This revision was automatically updated to reflect the committed changes.
jobnoorman added a commit: rGe96763894760: [JITLink][AArch64] Implement R_AARCH64_ADR_PREL_LO21.

Revision Contents
Changeset List

PathSize
llvm/
include/
llvm/
ExecutionEngine/
JITLink/
33 lines
lib/
ExecutionEngine/
JITLink/
12 lines
2 lines
test/
ExecutionEngine/
JITLink/
AArch64/
12 lines

Diff 529881

View Options

llvm/include/llvm/ExecutionEngine/JITLink/aarch64.h

Loading...
View Options

llvm/lib/ExecutionEngine/JITLink/ELF_aarch64.cpp

Loading...
View Options

llvm/lib/ExecutionEngine/JITLink/aarch64.cpp

Loading...
View Options

llvm/test/ExecutionEngine/JITLink/AArch64/ELF_relocations.s

Loading...