This is an archive of the discontinued LLVM Phabricator instance.

[OpenMP][NFC] clang-format the OpenMP device runtime
ClosedPublic

Authored by jhuber6 on May 23 2023, 9:10 AM.

Details

Summary

These files aren't fully formatted. I'm guessing this was a holdover
from when clang-format was totally broken for OpenMP offloading.
Format the files to be more consistent.

Diff Detail

Event Timeline

jhuber6 created this revision.May 23 2023, 9:10 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 23 2023, 9:10 AM
jhuber6 requested review of this revision.May 23 2023, 9:10 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 23 2023, 9:10 AM
jhuber6 updated this revision to Diff 524757.May 23 2023, 9:11 AM

Exports file got formatted accidentally.

This revision is now accepted and ready to land.May 23 2023, 9:18 AM
This revision was automatically updated to reflect the committed changes.

If anyone cares for usable git blame functionality across reformatting commits, we should add the openmp clang-format commits to the top-level .git-blame-ignore-revs file. Only commits with no further changes than formatting should be added to the file.
The file contains the command to configure the local git repo. GitHub respects this file for online blame view.

If anyone cares for usable git blame functionality across reformatting commits, we should add the openmp clang-format commits to the top-level .git-blame-ignore-revs file. Only commits with no further changes than formatting should be added to the file.
The file contains the command to configure the local git repo. GitHub respects this file for online blame view.

Didn't know about that, I'll keep it in mind. Thanks.

Since you need to know the commit hash, adding the formatting commit to the file is always a separate commit.