This is an archive of the discontinued LLVM Phabricator instance.

Differential D150899

[PowerPC] Add DFP compare instructions.
ClosedPublic

Authored by stefanp on May 18 2023, 12:09 PM.

Details

Reviewers
nemanjai
lei
amyk
power-llvm-team
Commits
rG94cefe41e6f2: [PowerPC] Add DFP compare instructions.
Summary

This patch adds the DFP compare instructions:
dcmpu, dcmpuq, dcmpo, dcmpoq

Diff Detail

Event Timeline

stefanp created this revision.May 18 2023, 12:09 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 18 2023, 12:09 PM
Herald added subscribers: shchenz, kbarton, hiraditya. · View Herald Transcript
stefanp requested review of this revision.May 18 2023, 12:09 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 18 2023, 12:09 PM
stefanp added a reviewer: power-llvm-team.May 18 2023, 12:17 PM
Harbormaster completed remote builds in B232965: Diff 523498.May 18 2023, 1:28 PM
amyk added a comment.May 19 2023, 11:11 AM

I think this patch looks OK to me, but I had one question regarding it.

llvm/lib/Target/PowerPC/PPCInstrDFP.td
40

I noticed some other compare instructions set hasSideEffects to 0 accordingly, but I was wondering if we need to do that here?

stefanp updated this revision to Diff 524838.May 23 2023, 12:10 PM

Missed a few flags for the instructions. Added them now.

llvm/lib/Target/PowerPC/PPCInstrDFP.td
40

Actually, I seem to have missed a few flags here and not just that one. I'll add the flags for this now.

Harbormaster completed remote builds in B233951: Diff 524838.May 23 2023, 2:05 PM
amyk accepted this revision.May 24 2023, 7:59 AM

Thanks for addressing my comment, Stefan.
I do not have any further comments/questions, so I'm going to approve this. LGTM.

This revision is now accepted and ready to land.May 24 2023, 7:59 AM
Closed by commit rG94cefe41e6f2: [PowerPC] Add DFP compare instructions. (authored by stefanp). · Explain WhyJun 2 2023, 9:48 AM
This revision was automatically updated to reflect the committed changes.
stefanp added a commit: rG94cefe41e6f2: [PowerPC] Add DFP compare instructions..

Revision Contents

PathSize
llvm/
lib/
Target/
PowerPC/
15 lines
test/
MC/
Disassembler/
PowerPC/
12 lines
PowerPC/
12 lines

Diff 523498

llvm/lib/Target/PowerPC/PPCInstrDFP.td

Show All 30 Lines
defm DMULQ : XForm_28r<63, 34, (outs fpairrc:$RST), (ins fpairrc:$RA, fpairrc:$RB), defm DMULQ : XForm_28r<63, 34, (outs fpairrc:$RST), (ins fpairrc:$RA, fpairrc:$RB),
"dmulq", "$RST, $RA, $RB", IIC_FPGeneral, []>; "dmulq", "$RST, $RA, $RB", IIC_FPGeneral, []>;
defm DDIV : XForm_28r<59, 546, (outs f8rc:$RST), (ins f8rc:$RA, f8rc:$RB), defm DDIV : XForm_28r<59, 546, (outs f8rc:$RST), (ins f8rc:$RA, f8rc:$RB),
"ddiv", "$RST, $RA, $RB", IIC_FPGeneral, []>; "ddiv", "$RST, $RA, $RB", IIC_FPGeneral, []>;
defm DDIVQ : XForm_28r<63, 546, (outs fpairrc:$RST), (ins fpairrc:$RA, fpairrc:$RB), defm DDIVQ : XForm_28r<63, 546, (outs fpairrc:$RST), (ins fpairrc:$RA, fpairrc:$RB),
"ddivq", "$RST, $RA, $RB", IIC_FPGeneral, []>; "ddivq", "$RST, $RA, $RB", IIC_FPGeneral, []>;
let isCompare = 1, mayRaiseFPException = 1 in {
amykUnsubmitted
Not Done
ReplyInline Actions

I noticed some other compare instructions set hasSideEffects to 0 accordingly, but I was wondering if we need to do that here?

amyk: I noticed some other compare instructions set `hasSideEffects` to 0 accordingly, but I was…
stefanpAuthorUnsubmitted
Done
ReplyInline Actions

Actually, I seem to have missed a few flags here and not just that one. I'll add the flags for this now.

stefanp: Actually, I seem to have missed a few flags here and not just that one. I'll add the flags for…
def DCMPU : XForm_17<59, 642, (outs crrc:$BF), (ins f8rc:$RA, f8rc:$RB),
"dcmpu $BF, $RA, $RB", IIC_FPCompare>;
def DCMPUQ : XForm_17<63, 642, (outs crrc:$BF), (ins fpairrc:$RA, fpairrc:$RB),
"dcmpuq $BF, $RA, $RB", IIC_FPCompare>;
def DCMPO : XForm_17<59, 130, (outs crrc:$BF), (ins f8rc:$RA, f8rc:$RB),
"dcmpo $BF, $RA, $RB", IIC_FPCompare>;
def DCMPOQ : XForm_17<63, 130, (outs crrc:$BF), (ins fpairrc:$RA, fpairrc:$RB),
"dcmpoq $BF, $RA, $RB", IIC_FPCompare>;
}
} }

llvm/test/MC/Disassembler/PowerPC/ppc64-encoding-dfp.txt

Show First 20 Lines • Show All 41 Lines • ▼ Show 20 Lines
# CHECK: ddiv. 2, 3, 4 # CHECK: ddiv. 2, 3, 4
0xec 0x43 0x24 0x45 0xec 0x43 0x24 0x45
# CHECK: ddivq 2, 6, 4 # CHECK: ddivq 2, 6, 4
0xfc 0x46 0x24 0x44 0xfc 0x46 0x24 0x44
# CHECK: ddivq. 2, 6, 4 # CHECK: ddivq. 2, 6, 4
0xfc 0x46 0x24 0x45 0xfc 0x46 0x24 0x45
# CHECK: dcmpu 2, 6, 4
0xed 0x06 0x25 0x04
# CHECK: dcmpuq 2, 6, 4
0xfd 0x06 0x25 0x04
# CHECK: dcmpo 2, 6, 4
0xed 0x06 0x21 0x04
# CHECK: dcmpoq 2, 6, 4
0xfd 0x06 0x21 0x04

llvm/test/MC/PowerPC/ppc64-encoding-dfp.s

Show First 20 Lines • Show All 44 Lines • ▼ Show 20 Lines
# CHECK-LE: ddiv. 2, 3, 4 # encoding: [0x45,0x24,0x43,0xec] # CHECK-LE: ddiv. 2, 3, 4 # encoding: [0x45,0x24,0x43,0xec]
ddiv. 2, 3, 4 ddiv. 2, 3, 4
# CHECK-BE: ddivq 2, 6, 4 # encoding: [0xfc,0x46,0x24,0x44] # CHECK-BE: ddivq 2, 6, 4 # encoding: [0xfc,0x46,0x24,0x44]
# CHECK-LE: ddivq 2, 6, 4 # encoding: [0x44,0x24,0x46,0xfc] # CHECK-LE: ddivq 2, 6, 4 # encoding: [0x44,0x24,0x46,0xfc]
ddivq 2, 6, 4 ddivq 2, 6, 4
# CHECK-BE: ddivq. 2, 6, 4 # encoding: [0xfc,0x46,0x24,0x45] # CHECK-BE: ddivq. 2, 6, 4 # encoding: [0xfc,0x46,0x24,0x45]
# CHECK-LE: ddivq. 2, 6, 4 # encoding: [0x45,0x24,0x46,0xfc] # CHECK-LE: ddivq. 2, 6, 4 # encoding: [0x45,0x24,0x46,0xfc]
ddivq. 2, 6, 4 ddivq. 2, 6, 4
# CHECK-BE: dcmpu 2, 6, 4 # encoding: [0xed,0x06,0x25,0x04]
# CHECK-LE: dcmpu 2, 6, 4 # encoding: [0x04,0x25,0x06,0xed]
dcmpu 2, 6, 4
# CHECK-BE: dcmpuq 2, 6, 4 # encoding: [0xfd,0x06,0x25,0x04]
# CHECK-LE: dcmpuq 2, 6, 4 # encoding: [0x04,0x25,0x06,0xfd]
dcmpuq 2, 6, 4
# CHECK-BE: dcmpo 2, 6, 4 # encoding: [0xed,0x06,0x21,0x04]
# CHECK-LE: dcmpo 2, 6, 4 # encoding: [0x04,0x21,0x06,0xed]
dcmpo 2, 6, 4
# CHECK-BE: dcmpoq 2, 6, 4 # encoding: [0xfd,0x06,0x21,0x04]
# CHECK-LE: dcmpoq 2, 6, 4 # encoding: [0x04,0x21,0x06,0xfd]
dcmpoq 2, 6, 4