This is an archive of the discontinued LLVM Phabricator instance.

[Support] Forward GenCrashDiag argument from report_fatal_error(Error, bool)
ClosedPublic

Authored by asb on May 16 2023, 7:20 AM.

Details

Summary

The boolean GenCrashDiag argument was previous just discarded, which seems to be an oversight that existed when this overload was first added.

Reviewers added based on those who last touched this function. I don't think there's an easy way to test this, but let me know if I'm wrong on that point.

Diff Detail

Event Timeline

asb created this revision.May 16 2023, 7:20 AM
asb requested review of this revision.May 16 2023, 7:20 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 16 2023, 7:20 AM
JDevlieghere accepted this revision.May 16 2023, 12:49 PM

Makes sense to me. LGTM.

This revision is now accepted and ready to land.May 16 2023, 12:49 PM
This revision was landed with ongoing or failed builds.May 17 2023, 3:17 AM
This revision was automatically updated to reflect the committed changes.