This is an archive of the discontinued LLVM Phabricator instance.

Differential D150584

[M68k] Do not require register scavenging during PEI
ClosedPublic

Authored by foad on May 15 2023, 9:10 AM.

Details

Reviewers
myhsu
0x59616e
Commits
rG7ca1bcbc6043: [M68k] Do not require register scavenging during PEI
Summary

Nothing in this target appears to use the scavenger.

Diff Detail

Unit TestsFailed

TimeTest
320 msx64 debian > Clang.Preprocessor::init.c
60,060 msx64 debian > MLIR.Examples/standalone::test.toy

Event Timeline

foad created this revision.May 15 2023, 9:10 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 15 2023, 9:10 AM
Herald added subscribers: StephenFan, hiraditya. · View Herald Transcript
foad requested review of this revision.May 15 2023, 9:10 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 15 2023, 9:10 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B232034: Diff 522224.May 15 2023, 11:43 AM
glaubitz added a reviewer: 0x59616e.May 16 2023, 5:53 AM
glaubitz added a subscriber: glaubitz.
myhsu accepted this revision.May 18 2023, 2:26 PM

LGTM Thanks! We're indeed not using any RegScavenger at this point.

This revision is now accepted and ready to land.May 18 2023, 2:26 PM
This revision was landed with ongoing or failed builds.May 19 2023, 1:05 AM
Closed by commit rG7ca1bcbc6043: [M68k] Do not require register scavenging during PEI (authored by foad). · Explain Why
This revision was automatically updated to reflect the committed changes.
foad added a commit: rG7ca1bcbc6043: [M68k] Do not require register scavenging during PEI.

Revision Contents

PathSize
llvm/
lib/
Target/
M68k/
2 lines

Diff 522224

llvm/lib/Target/M68k/M68kRegisterInfo.cpp

Show First 20 Lines • Show All 207 Lines • ▼ Show 20 Lines if (BasePtr == StackPtr)
FIOffset += SPAdj; FIOffset += SPAdj;
Disp.ChangeToImmediate(FIOffset + Imm); Disp.ChangeToImmediate(FIOffset + Imm);
return false; return false;
} }
bool M68kRegisterInfo::requiresRegisterScavenging( bool M68kRegisterInfo::requiresRegisterScavenging(
const MachineFunction &MF) const { const MachineFunction &MF) const {
return true; return false;
} }
bool M68kRegisterInfo::trackLivenessAfterRegAlloc( bool M68kRegisterInfo::trackLivenessAfterRegAlloc(
const MachineFunction &MF) const { const MachineFunction &MF) const {
return true; return true;
} }
static bool CantUseSP(const MachineFrameInfo &MFI) { static bool CantUseSP(const MachineFrameInfo &MFI) {
▲ Show 20 Lines • Show All 45 Lines • Show Last 20 Lines