This is an archive of the discontinued LLVM Phabricator instance.

Differential D150569

[unittests][llvm-exegesis] Remove build warnings [NFCI]
ClosedPublic

Authored by fpetrogalli on May 15 2023, 6:31 AM.

Details

Reviewers
fhahn
Commits
rG930421e18c51: [unittests][llvm-exegesis] Remove build warnings [NFCI]
Summary

Remove the warning caused by a missing field initializer.

The field is StartAtCycle of struct MCWriteProcResEntry.

It has been set to the default StartAtCycle = 0.

Diff Detail

Unit TestsFailed

TimeTest
60,040 msx64 debian > MLIR.Examples/standalone::test.toy

Event Timeline

fpetrogalli created this revision.May 15 2023, 6:31 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 15 2023, 6:31 AM
Herald added subscribers: StephenFan, mstojanovic, nemanjai. · View Herald Transcript
fpetrogalli requested review of this revision.May 15 2023, 6:31 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 15 2023, 6:31 AM
Herald added subscribers: llvm-commits, courbet. · View Herald Transcript
fpetrogalli mentioned this in D150310: [TableGen][SubtargetEmitter] Add the StartAtCycles field in the WriteRes class..May 15 2023, 6:32 AM
fhahn accepted this revision.May 15 2023, 6:45 AM

LGTM, thanks!

This revision is now accepted and ready to land.May 15 2023, 6:45 AM
fpetrogalli added a comment.May 15 2023, 6:51 AM
In D150569#4342206, @fhahn wrote:

LGTM, thanks!

De nada! :)

This revision was landed with ongoing or failed builds.May 15 2023, 6:53 AM
Closed by commit rG930421e18c51: [unittests][llvm-exegesis] Remove build warnings [NFCI] (authored by fpetrogalli). · Explain Why
This revision was automatically updated to reflect the committed changes.
fpetrogalli added a commit: rG930421e18c51: [unittests][llvm-exegesis] Remove build warnings [NFCI].
Harbormaster completed remote builds in B231986: Diff 522158.May 15 2023, 8:12 AM

Revision Contents

PathSize
llvm/
unittests/
tools/
llvm-exegesis/
PowerPC/
8 lines
X86/
8 lines

Diff 522158

llvm/unittests/tools/llvm-exegesis/PowerPC/AnalysisTest.cpp

Show First 20 Lines • Show All 65 Lines • ▼ Show 20 Linesprotected:
uint16_t ALUIdx = 0; uint16_t ALUIdx = 0;
uint16_t ALUEIdx = 0; uint16_t ALUEIdx = 0;
uint16_t ALUOIdx = 0; uint16_t ALUOIdx = 0;
uint16_t IPAGENIdx = 0; uint16_t IPAGENIdx = 0;
}; };
TEST_F(PPCAnalysisTest, ComputeIdealizedProcResPressure_2ALU) { TEST_F(PPCAnalysisTest, ComputeIdealizedProcResPressure_2ALU) {
const auto Pressure = const auto Pressure =
computeIdealizedProcResPressure(STI->getSchedModel(), {{ALUIdx, 2}}); computeIdealizedProcResPressure(STI->getSchedModel(), {{ALUIdx, 2, 0}});
EXPECT_THAT(Pressure, UnorderedElementsAre(Pair(ALUIdx, 2.0))); EXPECT_THAT(Pressure, UnorderedElementsAre(Pair(ALUIdx, 2.0)));
} }
TEST_F(PPCAnalysisTest, ComputeIdealizedProcResPressure_1ALUE) { TEST_F(PPCAnalysisTest, ComputeIdealizedProcResPressure_1ALUE) {
const auto Pressure = const auto Pressure =
computeIdealizedProcResPressure(STI->getSchedModel(), {{ALUEIdx, 2}}); computeIdealizedProcResPressure(STI->getSchedModel(), {{ALUEIdx, 2, 0}});
EXPECT_THAT(Pressure, UnorderedElementsAre(Pair(ALUEIdx, 2.0))); EXPECT_THAT(Pressure, UnorderedElementsAre(Pair(ALUEIdx, 2.0)));
} }
TEST_F(PPCAnalysisTest, ComputeIdealizedProcResPressure_1ALU1IPAGEN) { TEST_F(PPCAnalysisTest, ComputeIdealizedProcResPressure_1ALU1IPAGEN) {
const auto Pressure = const auto Pressure = computeIdealizedProcResPressure(
computeIdealizedProcResPressure(STI->getSchedModel(), {{ALUIdx, 1}, {IPAGENIdx, 1}}); STI->getSchedModel(), {{ALUIdx, 1, 0}, {IPAGENIdx, 1, 0}});
EXPECT_THAT(Pressure, UnorderedElementsAre(Pair(ALUIdx, 1.0),Pair(IPAGENIdx, 1))); EXPECT_THAT(Pressure, UnorderedElementsAre(Pair(ALUIdx, 1.0),Pair(IPAGENIdx, 1)));
} }
} // namespace } // namespace
} // namespace exegesis } // namespace exegesis
} // namespace llvm } // namespace llvm

llvm/unittests/tools/llvm-exegesis/X86/SchedClassResolutionTest.cpp

Show First 20 Lines • Show All 59 Lines • ▼ Show 20 Linesprotected:
uint16_t P5Idx = 0; uint16_t P5Idx = 0;
uint16_t P6Idx = 0; uint16_t P6Idx = 0;
uint16_t P05Idx = 0; uint16_t P05Idx = 0;
uint16_t P0156Idx = 0; uint16_t P0156Idx = 0;
}; };
TEST_F(X86SchedClassResolutionTest, ComputeIdealizedProcResPressure_2P0) { TEST_F(X86SchedClassResolutionTest, ComputeIdealizedProcResPressure_2P0) {
const auto Pressure = const auto Pressure =
computeIdealizedProcResPressure(STI.getSchedModel(), {{P0Idx, 2}}); computeIdealizedProcResPressure(STI.getSchedModel(), {{P0Idx, 2, 0}});
EXPECT_THAT(Pressure, UnorderedElementsAre(Pair(P0Idx, 2.0))); EXPECT_THAT(Pressure, UnorderedElementsAre(Pair(P0Idx, 2.0)));
} }
TEST_F(X86SchedClassResolutionTest, ComputeIdealizedProcResPressure_2P05) { TEST_F(X86SchedClassResolutionTest, ComputeIdealizedProcResPressure_2P05) {
const auto Pressure = const auto Pressure =
computeIdealizedProcResPressure(STI.getSchedModel(), {{P05Idx, 2}}); computeIdealizedProcResPressure(STI.getSchedModel(), {{P05Idx, 2, 0}});
EXPECT_THAT(Pressure, EXPECT_THAT(Pressure,
UnorderedElementsAre(Pair(P0Idx, 1.0), Pair(P5Idx, 1.0))); UnorderedElementsAre(Pair(P0Idx, 1.0), Pair(P5Idx, 1.0)));
} }
TEST_F(X86SchedClassResolutionTest, ComputeIdealizedProcResPressure_2P05_2P0156) { TEST_F(X86SchedClassResolutionTest, ComputeIdealizedProcResPressure_2P05_2P0156) {
const auto Pressure = computeIdealizedProcResPressure( const auto Pressure = computeIdealizedProcResPressure(
STI.getSchedModel(), {{P05Idx, 2}, {P0156Idx, 2}}); STI.getSchedModel(), {{P05Idx, 2, 0}, {P0156Idx, 2, 0}});
EXPECT_THAT(Pressure, EXPECT_THAT(Pressure,
UnorderedElementsAre(Pair(P0Idx, 1.0), Pair(P1Idx, 1.0), UnorderedElementsAre(Pair(P0Idx, 1.0), Pair(P1Idx, 1.0),
Pair(P5Idx, 1.0), Pair(P6Idx, 1.0))); Pair(P5Idx, 1.0), Pair(P6Idx, 1.0)));
} }
TEST_F(X86SchedClassResolutionTest, TEST_F(X86SchedClassResolutionTest,
ComputeIdealizedProcResPressure_1P1_1P05_2P0156) { ComputeIdealizedProcResPressure_1P1_1P05_2P0156) {
const auto Pressure = computeIdealizedProcResPressure( const auto Pressure = computeIdealizedProcResPressure(
STI.getSchedModel(), {{P1Idx, 1}, {P05Idx, 1}, {P0156Idx, 2}}); STI.getSchedModel(), {{P1Idx, 1, 0}, {P05Idx, 1, 0}, {P0156Idx, 2, 0}});
EXPECT_THAT(Pressure, EXPECT_THAT(Pressure,
UnorderedElementsAre(Pair(P0Idx, 1.0), Pair(P1Idx, 1.0), UnorderedElementsAre(Pair(P0Idx, 1.0), Pair(P1Idx, 1.0),
Pair(P5Idx, 1.0), Pair(P6Idx, 1.0))); Pair(P5Idx, 1.0), Pair(P6Idx, 1.0)));
} }
} // namespace } // namespace
} // namespace exegesis } // namespace exegesis
} // namespace llvm } // namespace llvm