This is an archive of the discontinued LLVM Phabricator instance.

[clang] Convert a few tests to opaque pointers
ClosedPublic

Authored by barannikov88 on May 14 2023, 3:49 AM.

Diff Detail

Event Timeline

barannikov88 created this revision.May 14 2023, 3:49 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 14 2023, 3:49 AM
barannikov88 requested review of this revision.May 14 2023, 3:49 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 14 2023, 3:49 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript

convert a few more tests

nikic accepted this revision.May 14 2023, 5:37 AM

LGTM

This revision is now accepted and ready to land.May 14 2023, 5:37 AM

convert a few more tests, last iteration

barannikov88 added a comment.EditedMay 14 2023, 5:50 AM

@nikic I converted a few more tests after you approved the changes. Please take a look once more, or let me know if I should revert to the previous revision.

nikic accepted this revision.May 14 2023, 5:52 AM

Still LGTM

Thanks. These were the lasts tests in these directories. The only one remaining is clang/test/CodeGenOpenCL/opaque-ptr-spirv.cl, I don't know what to do with it.

This revision was automatically updated to reflect the committed changes.
amyk added a subscriber: amyk.May 15 2023, 7:53 AM

Hi, I just wanted to give a heads up that it appears that this patch is causing failures on some of the PPC buildbots.
In particular, the const-str-array-decay.cl appears to be failing. The failing build can be seen in: https://lab.llvm.org/buildbot/#/builders/36/builds/33110

Hi, I just wanted to give a heads up that it appears that this patch is causing failures on some of the PPC buildbots.
In particular, the const-str-array-decay.cl appears to be failing. The failing build can be seen in: https://lab.llvm.org/buildbot/#/builders/36/builds/33110

Thanks!
I will be able to address this issue within a few hours. If it can't wait, please revert it.

Hi, I just wanted to give a heads up that it appears that this patch is causing failures on some of the PPC buildbots.
In particular, the const-str-array-decay.cl appears to be failing. The failing build can be seen in: https://lab.llvm.org/buildbot/#/builders/36/builds/33110

Should be fixed by https://reviews.llvm.org/rGcc7dc90481d93734a56098470879189cb2e2c127

amyk added a comment.May 15 2023, 10:19 AM

Hi, I just wanted to give a heads up that it appears that this patch is causing failures on some of the PPC buildbots.
In particular, the const-str-array-decay.cl appears to be failing. The failing build can be seen in: https://lab.llvm.org/buildbot/#/builders/36/builds/33110

Should be fixed by https://reviews.llvm.org/rGcc7dc90481d93734a56098470879189cb2e2c127

Thanks for the quick fix!