Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

TypeFinder: collect target types
AcceptedPublic

Authored by nhaehnle on May 11 2023, 7:36 AM.

Details

Summary

We will use this to output target type info when writing a module.

Diff Detail

Event Timeline

nhaehnle created this revision.May 11 2023, 7:36 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 11 2023, 7:36 AM
nhaehnle requested review of this revision.May 11 2023, 7:36 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 11 2023, 7:36 AM

Looks good to me. One question/nit inline.

llvm/include/llvm/IR/TypeFinder.h
72

As a getter, this should probably return StructType * instead of a reference?

nhaehnle updated this revision to Diff 523740.May 19 2023, 5:27 AM

Remove getStructType

llvm/include/llvm/IR/TypeFinder.h
72

It was a straight adjustment/rename of what used to be the operator[]; but it looks like that's unused? I'll double check and maybe just remove it.

nhaehnle marked an inline comment as done.May 19 2023, 5:27 AM
Flakebi accepted this revision.May 23 2023, 1:43 AM

Thanks!

This revision is now accepted and ready to land.May 23 2023, 1:43 AM