[tidy][IdentifierNaming] Fix crashes on non-identifiers

[PiotrZSL]

LGTM, fell free to deliver (to quickly fix crash).
Any improvements could be done later.

clang-tools-extra/clang-tidy/utils/RenamerClangTidyCheck.cpp

461

Most probably this could be done before for, as overridden/cannonical decl should have same naming.
And looks we get here from VisitMemberExpr.

clang-tools-extra/test/clang-tidy/checkers/readability/identifier-naming-nocrash.cpp

3–5 ↗

(On Diff #520633)

i would merge this with some existing test file...

[PiotrZSL]

clang-tools-extra/test/clang-tidy/checkers/readability/identifier-naming-nocrash.cpp

3–5 ↗

(On Diff #520633)

yep, tests fails due to lack of CHECK_MESSGAES, merge this with some other test file, main one for example.

[kadircet]

Merge with existing tests
Perform check earlier

[VitaNuo]

clang-tools-extra/clang-tidy/utils/RenamerClangTidyCheck.cpp

461

Could you do an early return instead? I believe it's clearer.

clang-tools-extra/clang-tidy/utils/RenamerClangTidyCheck.cpp

if (SourceMgr && SourceMgr->isWrittenInScratchSpace(FixLocation))
     Failure.FixStatus = RenamerClangTidyCheck::ShouldFixStatus::InsideMacro;
 
   if (!utils::rangeCanBeFixed(Range, SourceMgr))
     Failure.FixStatus = RenamerClangTidyCheck::ShouldFixStatus::InsideMacro;
 }
 
 void RenamerClangTidyCheck::addUsage(const NamedDecl *Decl, SourceRange Range,
                                      const SourceManager *SourceMgr) {
+  // Don't keep track for non-identifier names.
+  auto *II = Decl->getIdentifier();
+  if (!II)
+    return;
   if (const auto *Method = dyn_cast<CXXMethodDecl>(Decl)) {
     if (const CXXMethodDecl *Overridden = getOverrideMethod(Method))
       Decl = Overridden;
   }
   Decl = cast<NamedDecl>(Decl->getCanonicalDecl());
-  return addUsage(RenamerClangTidyCheck::NamingCheckId(Decl->getLocation(),
-                                                       Decl->getName()),
-                  Range, SourceMgr);
+  return addUsage(
+      RenamerClangTidyCheck::NamingCheckId(Decl->getLocation(), II->getName()),
 }
 
 void RenamerClangTidyCheck::checkNamedDecl(const NamedDecl *Decl,
                                            const SourceManager &SourceMgr) {
   std::optional<FailureInfo> MaybeFailure = getDeclFailureInfo(Decl, SourceMgr);
   if (!MaybeFailure)
     return;
 

clang-tools-extra/test/clang-tidy/checkers/readability/identifier-naming-bugfix.cpp

 // RUN: %check_clang_tidy -expect-clang-tidy-error %s readability-identifier-naming %t
 
 // This used to cause a null pointer dereference.
 auto [left] = right;
 // CHECK-MESSAGES: :[[@LINE-1]]:15: error: use of undeclared identifier 'right'
+
+namespace crash_on_nonidentifiers {
+struct Foo {
+  operator bool();
+};
+void foo() {
+  // Make sure we don't crash on non-identifier names (e.g. conversion
+  // operators).
+  if (Foo()) {}
+}
+}