[tidy][IdentifierNaming] Fix crashes on non-identifiers

[PiotrZSL]

LGTM, fell free to deliver (to quickly fix crash).
Any improvements could be done later.

clang-tools-extra/clang-tidy/utils/RenamerClangTidyCheck.cpp

457

Most probably this could be done before for, as overridden/cannonical decl should have same naming.
And looks we get here from VisitMemberExpr.

clang-tools-extra/test/clang-tidy/checkers/readability/identifier-naming-nocrash.cpp

3–5

i would merge this with some existing test file...

[PiotrZSL]

clang-tools-extra/test/clang-tidy/checkers/readability/identifier-naming-nocrash.cpp

3–5

yep, tests fails due to lack of CHECK_MESSGAES, merge this with some other test file, main one for example.

[kadircet]

Merge with existing tests
Perform check earlier

[VitaNuo]

clang-tools-extra/clang-tidy/utils/RenamerClangTidyCheck.cpp

457

Could you do an early return instead? I believe it's clearer.

clang-tools-extra/clang-tidy/utils/RenamerClangTidyCheck.cpp

 
 void RenamerClangTidyCheck::addUsage(const NamedDecl *Decl, SourceRange Range,
                                      const SourceManager *SourceMgr) {
   if (const auto *Method = dyn_cast<CXXMethodDecl>(Decl)) {
     if (const CXXMethodDecl *Overridden = getOverrideMethod(Method))
       Decl = Overridden;
   }
   Decl = cast<NamedDecl>(Decl->getCanonicalDecl());
+  // Don't keep track for non-identifier names.
+  if (auto *II = Decl->getIdentifier()) {
     return addUsage(RenamerClangTidyCheck::NamingCheckId(Decl->getLocation(),
-                                                       Decl->getName()),
+                                                         II->getName()),
                     Range, SourceMgr);
   }
+}
 
 void RenamerClangTidyCheck::checkNamedDecl(const NamedDecl *Decl,
                                            const SourceManager &SourceMgr) {
   std::optional<FailureInfo> MaybeFailure = getDeclFailureInfo(Decl, SourceMgr);
   if (!MaybeFailure)
     return;
 
   FailureInfo &Info = *MaybeFailure;

clang-tools-extra/test/clang-tidy/checkers/readability/identifier-naming-nocrash.cpp

+// RUN: %check_clang_tidy %s readability-identifier-naming %t
+
+struct Foo {
+  operator bool();
+};
+
+void foo() {
+  // Make sure we don't crash on non-identifier names (e.g. conversion
+  // operators).
+  if (Foo()) {}
+}