Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

VitaNuo (Viktoriia Bakalova)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 22 2022, 6:01 AM (43 w, 5 d)

Recent Activity

Tue, Sep 12

VitaNuo added a comment to D153769: [clangd] Implement the 'Organize Imports' source action. Fix include-cleaner findings in batch..

Respond to comments.

Tue, Sep 12, 12:54 AM · Restricted Project, Restricted Project
VitaNuo abandoned D159498: [clangd] Implement the 'Organize Imports' source action. Fix include-cleaner findings in batch..
Tue, Sep 12, 12:49 AM · Restricted Project, Restricted Project
VitaNuo added a comment to D153769: [clangd] Implement the 'Organize Imports' source action. Fix include-cleaner findings in batch..

I think I also managed to update the wrong patch. Not sure how an alternative patch got created in the first place :( Sorry for the mess, should be fine now.

Tue, Sep 12, 12:48 AM · Restricted Project, Restricted Project
VitaNuo updated the diff for D153769: [clangd] Implement the 'Organize Imports' source action. Fix include-cleaner findings in batch..

Address review comments.

Tue, Sep 12, 12:47 AM · Restricted Project, Restricted Project
VitaNuo added a comment to D153769: [clangd] Implement the 'Organize Imports' source action. Fix include-cleaner findings in batch..

I'm sorry I think the upload failed because I tried to upload without a message or something, and I didn't notice that it failed :(

Tue, Sep 12, 12:33 AM · Restricted Project, Restricted Project
VitaNuo updated the diff for D159498: [clangd] Implement the 'Organize Imports' source action. Fix include-cleaner findings in batch..

Address comments.

Tue, Sep 12, 12:32 AM · Restricted Project, Restricted Project

Mon, Sep 11

VitaNuo requested review of D159498: [clangd] Implement the 'Organize Imports' source action. Fix include-cleaner findings in batch..
Mon, Sep 11, 9:16 AM · Restricted Project, Restricted Project
VitaNuo added a comment to D153769: [clangd] Implement the 'Organize Imports' source action. Fix include-cleaner findings in batch..

Thank you for the comments!

Mon, Sep 11, 9:16 AM · Restricted Project, Restricted Project
VitaNuo committed rG13e5fafb5548: [clangd] Fix buildbot breakages from stemming from… (authored by VitaNuo).
[clangd] Fix buildbot breakages from stemming from…
Mon, Sep 11, 1:30 AM · Restricted Project, Restricted Project
VitaNuo committed rG64366d4935d3: [clangd] Rollforward include-cleaner library usage in symbol collector. (authored by VitaNuo).
[clangd] Rollforward include-cleaner library usage in symbol collector.
Mon, Sep 11, 12:57 AM · Restricted Project, Restricted Project
VitaNuo closed D156659: [clangd] Rollforward include-cleaner library usage in symbol collector..
Mon, Sep 11, 12:57 AM · Restricted Project, Restricted Project, Restricted Project

Thu, Sep 7

VitaNuo updated the diff for D156659: [clangd] Rollforward include-cleaner library usage in symbol collector..

Address comments.

Thu, Sep 7, 6:04 AM · Restricted Project, Restricted Project, Restricted Project
VitaNuo added inline comments to D156659: [clangd] Rollforward include-cleaner library usage in symbol collector..
Thu, Sep 7, 6:04 AM · Restricted Project, Restricted Project, Restricted Project
VitaNuo added a comment to D156659: [clangd] Rollforward include-cleaner library usage in symbol collector..

Thanks!

Thu, Sep 7, 5:08 AM · Restricted Project, Restricted Project, Restricted Project
VitaNuo updated the diff for D156659: [clangd] Rollforward include-cleaner library usage in symbol collector..

Address the comment.

Thu, Sep 7, 5:08 AM · Restricted Project, Restricted Project, Restricted Project
VitaNuo added inline comments to D156659: [clangd] Rollforward include-cleaner library usage in symbol collector..
Thu, Sep 7, 4:40 AM · Restricted Project, Restricted Project, Restricted Project
VitaNuo committed rG43c20367f417: [include-cleaner][clangd][clang-tidy] Ignore resource dir during include… (authored by VitaNuo).
[include-cleaner][clangd][clang-tidy] Ignore resource dir during include…
Thu, Sep 7, 4:40 AM · Restricted Project, Restricted Project
VitaNuo closed D157610: [include-cleaner][clangd][clang-tidy] Ignore resource dir during include-cleaner analysis..
Thu, Sep 7, 4:39 AM · Restricted Project, Restricted Project
VitaNuo added a comment to D157610: [include-cleaner][clangd][clang-tidy] Ignore resource dir during include-cleaner analysis..

Thanks!

Thu, Sep 7, 4:35 AM · Restricted Project, Restricted Project
VitaNuo updated the diff for D157610: [include-cleaner][clangd][clang-tidy] Ignore resource dir during include-cleaner analysis..

Address review comments.

Thu, Sep 7, 4:35 AM · Restricted Project, Restricted Project

Wed, Sep 6

VitaNuo committed rG625891288087: [clangd][clang-tidy] Add missing symbols to the symbol map. (authored by VitaNuo).
[clangd][clang-tidy] Add missing symbols to the symbol map.
Wed, Sep 6, 6:43 AM · Restricted Project, Restricted Project
VitaNuo closed D159462: [clangd][clang-tidy] Add missing symbols to the symbol map..
Wed, Sep 6, 6:42 AM · Restricted Project, Restricted Project
VitaNuo committed rGd71adebb9fb8: [include-cleaner] Map the 4-argument move overload to the algorithm header. (authored by VitaNuo).
[include-cleaner] Map the 4-argument move overload to the algorithm header.
Wed, Sep 6, 4:39 AM · Restricted Project, Restricted Project
VitaNuo closed D159463: [include-cleaner] Map the 4-argument move overload to the algorithm header..
Wed, Sep 6, 4:39 AM · Restricted Project, Restricted Project
VitaNuo updated the diff for D156659: [clangd] Rollforward include-cleaner library usage in symbol collector..

Address review comments.

Wed, Sep 6, 4:32 AM · Restricted Project, Restricted Project, Restricted Project
VitaNuo added a reviewer for D159463: [include-cleaner] Map the 4-argument move overload to the algorithm header.: kadircet.
Wed, Sep 6, 4:27 AM · Restricted Project, Restricted Project
VitaNuo requested review of D159463: [include-cleaner] Map the 4-argument move overload to the algorithm header..
Wed, Sep 6, 4:27 AM · Restricted Project, Restricted Project
VitaNuo added a reviewer for D159462: [clangd][clang-tidy] Add missing symbols to the symbol map.: kadircet.
Wed, Sep 6, 2:55 AM · Restricted Project, Restricted Project
VitaNuo requested review of D159462: [clangd][clang-tidy] Add missing symbols to the symbol map..
Wed, Sep 6, 2:54 AM · Restricted Project, Restricted Project
VitaNuo updated the diff for D157610: [include-cleaner][clangd][clang-tidy] Ignore resource dir during include-cleaner analysis..

Rebase to current main.

Wed, Sep 6, 2:49 AM · Restricted Project, Restricted Project
VitaNuo added a comment to D157610: [include-cleaner][clangd][clang-tidy] Ignore resource dir during include-cleaner analysis..

Thanks for the help in resolving the resource dir issues!

Wed, Sep 6, 1:44 AM · Restricted Project, Restricted Project
VitaNuo updated the diff for D157610: [include-cleaner][clangd][clang-tidy] Ignore resource dir during include-cleaner analysis..

Fix analysis test to properly recognize the resource directory.
Use HeaderSearch->getModuleMap().BuiltinDir to find out the resource directory.

Wed, Sep 6, 1:43 AM · Restricted Project, Restricted Project

Aug 11 2023

VitaNuo added a comment to D157610: [include-cleaner][clangd][clang-tidy] Ignore resource dir during include-cleaner analysis..

Thanks for the comments!

Aug 11 2023, 10:00 AM · Restricted Project, Restricted Project
VitaNuo updated the diff for D157610: [include-cleaner][clangd][clang-tidy] Ignore resource dir during include-cleaner analysis..

Address review comments.

Aug 11 2023, 9:43 AM · Restricted Project, Restricted Project

Aug 10 2023

VitaNuo added a reviewer for D157610: [include-cleaner][clangd][clang-tidy] Ignore resource dir during include-cleaner analysis.: kadircet.
Aug 10 2023, 6:14 AM · Restricted Project, Restricted Project
VitaNuo requested review of D157610: [include-cleaner][clangd][clang-tidy] Ignore resource dir during include-cleaner analysis..
Aug 10 2023, 6:11 AM · Restricted Project, Restricted Project

Aug 9 2023

VitaNuo committed rGc3ad4b763602: [include-cleaner] Follow `IWYU pragma: export` links transitively. (authored by VitaNuo).
[include-cleaner] Follow `IWYU pragma: export` links transitively.
Aug 9 2023, 5:11 AM · Restricted Project, Restricted Project
VitaNuo closed D157395: [include-cleaner] Follow `IWYU pragma: export` links transitively..
Aug 9 2023, 5:10 AM · Restricted Project, Restricted Project
VitaNuo updated the diff for D157395: [include-cleaner] Follow `IWYU pragma: export` links transitively..

Add a test with private headers involved. Order of exporters is from outermost to innermost.

Aug 9 2023, 3:24 AM · Restricted Project, Restricted Project
VitaNuo updated the diff for D157395: [include-cleaner] Follow `IWYU pragma: export` links transitively..

Address the comments.

Aug 9 2023, 3:05 AM · Restricted Project, Restricted Project

Aug 8 2023

VitaNuo accepted D157400: [include-cleaner] Dont boost private headers beyond public ones.

Thanks.

Aug 8 2023, 9:03 AM · Restricted Project, Restricted Project
VitaNuo updated the diff for D157395: [include-cleaner] Follow `IWYU pragma: export` links transitively..

Remove the preferred header hint for exporters.

Aug 8 2023, 7:36 AM · Restricted Project, Restricted Project
VitaNuo added a reviewer for D157395: [include-cleaner] Follow `IWYU pragma: export` links transitively.: kadircet.
Aug 8 2023, 7:05 AM · Restricted Project, Restricted Project
VitaNuo updated the diff for D157395: [include-cleaner] Follow `IWYU pragma: export` links transitively..

Remove accidental comment.

Aug 8 2023, 7:02 AM · Restricted Project, Restricted Project
VitaNuo requested review of D157395: [include-cleaner] Follow `IWYU pragma: export` links transitively..
Aug 8 2023, 6:58 AM · Restricted Project, Restricted Project
VitaNuo accepted D157390: [clang-tidy][include-cleaner] Add option to control deduplication of findings per symbol.

Thanks.

Aug 8 2023, 6:26 AM · Restricted Project, Restricted Project

Aug 7 2023

VitaNuo committed rG8a5c0ccee293: [clangd][clang-tidy][std_symbol_map] Add missing symbol. (authored by VitaNuo).
[clangd][clang-tidy][std_symbol_map] Add missing symbol.
Aug 7 2023, 1:42 AM · Restricted Project, Restricted Project
VitaNuo closed D157256: [clangd][clang-tidy][std_symbol_map] Add missing symbol..
Aug 7 2023, 1:42 AM · Restricted Project, Restricted Project
VitaNuo requested review of D157256: [clangd][clang-tidy][std_symbol_map] Add missing symbol..
Aug 7 2023, 12:53 AM · Restricted Project, Restricted Project

Aug 4 2023

VitaNuo committed rG5d492766a8fb: [clangd][clang-tidy][stdlib] Add a missing symbol to the mapping. (authored by VitaNuo).
[clangd][clang-tidy][stdlib] Add a missing symbol to the mapping.
Aug 4 2023, 7:16 AM · Restricted Project, Restricted Project
VitaNuo closed D157093: [clangd][clang-tidy][stdlib] Add a missing symbol to the mapping..
Aug 4 2023, 7:15 AM · Restricted Project, Restricted Project
VitaNuo added a reviewer for D157093: [clangd][clang-tidy][stdlib] Add a missing symbol to the mapping.: kadircet.
Aug 4 2023, 6:47 AM · Restricted Project, Restricted Project
VitaNuo requested review of D157093: [clangd][clang-tidy][stdlib] Add a missing symbol to the mapping..
Aug 4 2023, 6:46 AM · Restricted Project, Restricted Project

Aug 1 2023

VitaNuo added a comment to D156123: [include-cleaner] Unify always_keep with rest of the keep logic.

Thanks!

Aug 1 2023, 8:14 AM · Restricted Project, Restricted Project
VitaNuo accepted D156123: [include-cleaner] Unify always_keep with rest of the keep logic.
Aug 1 2023, 8:13 AM · Restricted Project, Restricted Project
VitaNuo accepted D156122: [include-cleaner] Introduce support for always_keep pragma.

Thanks!

Aug 1 2023, 5:43 AM · Restricted Project, Restricted Project

Jul 31 2023

VitaNuo abandoned D145059: [clangd] Add support from showing used symbols on cross ref request.
Jul 31 2023, 5:39 AM · Restricted Project, Restricted Project
VitaNuo added inline comments to D156123: [include-cleaner] Unify always_keep with rest of the keep logic.
Jul 31 2023, 5:16 AM · Restricted Project, Restricted Project
VitaNuo added inline comments to D156122: [include-cleaner] Introduce support for always_keep pragma.
Jul 31 2023, 5:16 AM · Restricted Project, Restricted Project
VitaNuo added a reviewer for D156659: [clangd] Rollforward include-cleaner library usage in symbol collector.: kadircet.
Jul 31 2023, 2:54 AM · Restricted Project, Restricted Project, Restricted Project
VitaNuo requested review of D156659: [clangd] Rollforward include-cleaner library usage in symbol collector..
Jul 31 2023, 2:52 AM · Restricted Project, Restricted Project, Restricted Project

Jul 27 2023

VitaNuo added a comment to D153769: [clangd] Implement the 'Organize Imports' source action. Fix include-cleaner findings in batch..

Thanks for the comments!

Jul 27 2023, 6:58 AM · Restricted Project, Restricted Project
VitaNuo updated the diff for D153769: [clangd] Implement the 'Organize Imports' source action. Fix include-cleaner findings in batch..

Address review comments. Update the action to trigger when source action is requested explicitly or from the preamble range. Add unit test.

Jul 27 2023, 6:47 AM · Restricted Project, Restricted Project
VitaNuo committed rG3c6a7b0045af: [clangd] Revert the symbol collector behavior to old pre-include-cleaner… (authored by VitaNuo).
[clangd] Revert the symbol collector behavior to old pre-include-cleaner…
Jul 27 2023, 3:35 AM · Restricted Project, Restricted Project
VitaNuo closed D156403: [clangd] Revert the symbol collector behavior to old pre-include-cleaner-library behavior due to a regression..
Jul 27 2023, 3:34 AM · Restricted Project, Restricted Project
VitaNuo updated the diff for D156403: [clangd] Revert the symbol collector behavior to old pre-include-cleaner-library behavior due to a regression..

Address comment.

Jul 27 2023, 3:33 AM · Restricted Project, Restricted Project
VitaNuo updated the diff for D156403: [clangd] Revert the symbol collector behavior to old pre-include-cleaner-library behavior due to a regression..

Address comments.

Jul 27 2023, 3:16 AM · Restricted Project, Restricted Project
VitaNuo added a reviewer for D156403: [clangd] Revert the symbol collector behavior to old pre-include-cleaner-library behavior due to a regression.: kadircet.
Jul 27 2023, 1:44 AM · Restricted Project, Restricted Project
VitaNuo requested review of D156403: [clangd] Revert the symbol collector behavior to old pre-include-cleaner-library behavior due to a regression..
Jul 27 2023, 1:44 AM · Restricted Project, Restricted Project

Jul 19 2023

VitaNuo committed rG1f7c7d4bdd7b: [clangd] Update symbol collector to use include-cleaner. (authored by VitaNuo).
[clangd] Update symbol collector to use include-cleaner.
Jul 19 2023, 6:47 AM · Restricted Project, Restricted Project
VitaNuo closed D152900: [clangd] Update symbol collector to use include-cleaner..
Jul 19 2023, 6:47 AM · Restricted Project, Restricted Project
VitaNuo updated the diff for D152900: [clangd] Update symbol collector to use include-cleaner..

Address the latest comment batch.

Jul 19 2023, 6:45 AM · Restricted Project, Restricted Project
VitaNuo committed rG22605f5f1bf8: [clangd] Make an include always refer to itself. Background: clang-review… (authored by VitaNuo).
[clangd] Make an include always refer to itself. Background: clang-review…
Jul 19 2023, 1:33 AM · Restricted Project, Restricted Project
VitaNuo closed D155614: [clangd] Remove redundant emptiness check in cross ref calculation for includes..
Jul 19 2023, 1:33 AM · Restricted Project, Restricted Project
VitaNuo accepted D155614: [clangd] Remove redundant emptiness check in cross ref calculation for includes..
Jul 19 2023, 1:30 AM · Restricted Project, Restricted Project
VitaNuo updated the diff for D155614: [clangd] Remove redundant emptiness check in cross ref calculation for includes..

Remove only one of the checks.

Jul 19 2023, 1:29 AM · Restricted Project, Restricted Project
VitaNuo retitled D155614: [clangd] Remove redundant emptiness check in cross ref calculation for includes. from [clangd] Make an include always refer to itself. Background: clang-review expects all referents to have definition, declaration or reference(s). to [clangd] Remove redundant emptiness check in cross ref calculation for includes..
Jul 19 2023, 1:25 AM · Restricted Project, Restricted Project

Jul 18 2023

VitaNuo added a reviewer for D155614: [clangd] Remove redundant emptiness check in cross ref calculation for includes.: usaxena95.
Jul 18 2023, 9:34 AM · Restricted Project, Restricted Project
VitaNuo added a reviewer for D155614: [clangd] Remove redundant emptiness check in cross ref calculation for includes.: kadircet.
Jul 18 2023, 8:50 AM · Restricted Project, Restricted Project
VitaNuo requested review of D155614: [clangd] Remove redundant emptiness check in cross ref calculation for includes..
Jul 18 2023, 8:48 AM · Restricted Project, Restricted Project

Jul 14 2023

VitaNuo committed rG96e50797d6ea: [clangd] Fix the range for include reference to itself. (authored by VitaNuo).
[clangd] Fix the range for include reference to itself.
Jul 14 2023, 5:52 AM · Restricted Project, Restricted Project
VitaNuo closed D155215: [clangd] Fix the range for include reference to itself..
Jul 14 2023, 5:51 AM · Restricted Project, Restricted Project
VitaNuo added a comment to D155215: [clangd] Fix the range for include reference to itself..

Thanks for the comments!

Jul 14 2023, 5:49 AM · Restricted Project, Restricted Project
VitaNuo updated the diff for D155215: [clangd] Fix the range for include reference to itself..

Address comments.

Jul 14 2023, 5:48 AM · Restricted Project, Restricted Project
VitaNuo added a reviewer for D155215: [clangd] Fix the range for include reference to itself.: kadircet.
Jul 14 2023, 1:46 AM · Restricted Project, Restricted Project
VitaNuo updated the diff for D155215: [clangd] Fix the range for include reference to itself..

Re-use the logic from include cleaner in clangd.

Jul 14 2023, 1:45 AM · Restricted Project, Restricted Project
VitaNuo added a comment to D155217: [clang-tidy][include-cleaner] Don't warn for the same symbol twice.

Hi Alex,

Jul 14 2023, 1:02 AM · Restricted Project, Restricted Project

Jul 13 2023

VitaNuo removed a reviewer for D155215: [clangd] Fix the range for include reference to itself.: kadircet.
Jul 13 2023, 9:33 AM · Restricted Project, Restricted Project
VitaNuo added a reviewer for D155215: [clangd] Fix the range for include reference to itself.: kadircet.
Jul 13 2023, 9:27 AM · Restricted Project, Restricted Project
VitaNuo requested review of D155215: [clangd] Fix the range for include reference to itself..
Jul 13 2023, 9:26 AM · Restricted Project, Restricted Project
VitaNuo updated the diff for D152900: [clangd] Update symbol collector to use include-cleaner..

Address review comments.

Jul 13 2023, 2:32 AM · Restricted Project, Restricted Project
VitaNuo added a comment to D152900: [clangd] Update symbol collector to use include-cleaner..

Thank you!

Jul 13 2023, 2:31 AM · Restricted Project, Restricted Project

Jul 11 2023

VitaNuo committed rG7322f2d5ed54: [clangd] Use canonical path as resolved path for includes. (authored by VitaNuo).
[clangd] Use canonical path as resolved path for includes.
Jul 11 2023, 8:37 AM · Restricted Project, Restricted Project
VitaNuo closed D154962: [clangd] Use canonical path as resolved path for includes..
Jul 11 2023, 8:36 AM · Restricted Project, Restricted Project
VitaNuo added a comment to D154962: [clangd] Use canonical path as resolved path for includes..

Thanks.

Jul 11 2023, 8:34 AM · Restricted Project, Restricted Project
VitaNuo updated the diff for D154962: [clangd] Use canonical path as resolved path for includes..

Address comment.

Jul 11 2023, 8:32 AM · Restricted Project, Restricted Project
VitaNuo added a reviewer for D154962: [clangd] Use canonical path as resolved path for includes.: kadircet.
Jul 11 2023, 6:35 AM · Restricted Project, Restricted Project
VitaNuo requested review of D154962: [clangd] Use canonical path as resolved path for includes..
Jul 11 2023, 6:34 AM · Restricted Project, Restricted Project

Jun 29 2023

VitaNuo accepted D154068: [clangd] Don't show header for namespace decl in Hover.

Thanks!

Jun 29 2023, 5:43 AM · Restricted Project, Restricted Project
VitaNuo added a comment to D152900: [clangd] Update symbol collector to use include-cleaner..

Thanks for comments!

Jun 29 2023, 5:37 AM · Restricted Project, Restricted Project