This is an archive of the discontinued LLVM Phabricator instance.

[OpenMP][Libomptarget] Enable up to 64 arguments for outlined regions in OpenMP device code
ClosedPublic

Authored by doru1004 on May 8 2023, 12:03 PM.

Details

Summary

Enable up to 64 arguments for outlined regions in OpenMP device code.

Issue: https://github.com/llvm/llvm-project/issues/56389

Diff Detail

Event Timeline

doru1004 created this revision.May 8 2023, 12:03 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 8 2023, 12:03 PM
doru1004 requested review of this revision.May 8 2023, 12:03 PM

Maybe we should commandeer https://reviews.llvm.org/D129197 instead?

Maybe we should commandeer https://reviews.llvm.org/D129197 instead?

I think you mean to link this patch: https://reviews.llvm.org/D102107

I don't see that patch landing any time soon so in the meantime I think we should land the fix in this patch.

doru1004 edited the summary of this revision. (Show Details)May 8 2023, 12:50 PM

Maybe we should commandeer https://reviews.llvm.org/D129197 instead?

Thanks for pointing out that patch, I will close both once the fix lands!

jhuber6 accepted this revision.May 24 2023, 6:32 AM

I previously clang-formatted this file so you'll want to do that. But I don't see any problem landing this for the time being since it seems the aggregate patch is going nowhere fast.

This revision is now accepted and ready to land.May 24 2023, 6:32 AM