This is an archive of the discontinued LLVM Phabricator instance.

[OpenMP] enable kernel launches up to 64 params
Needs RevisionPublic

Authored by FabioLuporini on Jul 6 2022, 6:07 AM.

Details

Reviewers
jdoerfert

Diff Detail

Event Timeline

FabioLuporini created this revision.Jul 6 2022, 6:07 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 6 2022, 6:07 AM
FabioLuporini requested review of this revision.Jul 6 2022, 6:07 AM
Herald added a project: Restricted Project. · View Herald Transcript

Is there any hardware limitation on the max number of function arguments?

I checked earlier and AFAICT the only limitation is on the cumulative size which cannot exceed 4K (as of devices with CC>1 to be precise)

jdoerfert requested changes to this revision.Jul 6 2022, 7:04 AM

The right fix is to finally land D102107. Past attempts caused build failures. We should rebase and try again.

This revision now requires changes to proceed.Jul 6 2022, 7:04 AM

yep, I see, makes sense.

Do you have an ETA on that by any chance?

Many thanks for the quick feedback.

yep, I see, makes sense.

Do you have an ETA on that by any chance?

Many thanks for the quick feedback.

As you can see, nobody worked on it for a while. I have given it a ping. If you feel like helping to rebase it and update the clang tests, let me know.
The auto-generated tests should probably be reverted to community HEAD and then generated with the patch applied.