P0960R3 and P1975R0 were marked not implemented because
of #61145,
This issue has been fixed and backported to LLVM 16,
the status page should reflect that.
Differential D150122
[Clang] Fix status of P0960 cor3ntin on May 8 2023, 8:27 AM. Authored by
Details
P0960R3 and P1975R0 were marked not implemented because This issue has been fixed and backported to LLVM 16,
Diff Detail
Event TimelineComment Actions @aaron.ballman @erichkeane I'll merge that later today unless you see a reason not to. Comment Actions I've got no problems with this. I'm a little suspicious of marking this done in clang-16 if this was done only at the end of the branch though? And do we know there is going to be another Clang 16 release? Comment Actions Yes, I was asking myself the same question, I have no issue being conservative and saying 17 instead. Comment Actions I believe we are having another release of Clang 16, but @tstellar can confirm or deny that. AIUI, there were a few issues holding us back from claiming complete support (added @ayzhao as a reviewer in case he has a different opinion): If we backport the two other issues to 16, then I think the changes in this review are fine. If we don't backport those two, I think we should claim Clang 17 to be conservative. Comment Actions I started the backporting process for the remaining 2 bugs. I'm doing https://github.com/llvm/llvm-project/issues/62266 first before doing https://github.com/llvm/llvm-project/issues/61567 because otherwise there will be a merge issue. Once those two commits are backported then this patch LGTM. Comment Actions Status update on backports:
Comment Actions Sorry, but there's actually one more crash that was just reported earlier this week: https://github.com/llvm/llvm-project/issues/63008. We should wait until the backport PR has been approved. |