[Clang] Fix status of P0960

[cor3ntin]

Summary

P0960R3 and P1975R0 were marked not implemented because
of #61145,

This issue has been fixed and backported to LLVM 16,
the status page should reflect that.

[cor3ntin]

@aaron.ballman @erichkeane I'll merge that later today unless you see a reason not to.

[erichkeane]

I've got no problems with this. I'm a little suspicious of marking this done in clang-16 if this was done only at the end of the branch though? And do we know there is going to be another Clang 16 release?

[cor3ntin]

In D150122#4326935, @erichkeane wrote:

I've got no problems with this. I'm a little suspicious of marking this done in clang-16 if this was done only at the end of the branch though? And do we know there is going to be another Clang 16 release?

Yes, I was asking myself the same question, I have no issue being conservative and saying 17 instead.

[erichkeane]

In D150122#4326941, @cor3ntin wrote:

In D150122#4326935, @erichkeane wrote:

I've got no problems with this. I'm a little suspicious of marking this done in clang-16 if this was done only at the end of the branch though? And do we know there is going to be another Clang 16 release?

Yes, I was asking myself the same question, I have no issue being conservative and saying 17 instead.

Perhaps worth making Aaron make the decision :D

[aaron.ballman]

I believe we are having another release of Clang 16, but @tstellar can confirm or deny that.

AIUI, there were a few issues holding us back from claiming complete support (added @ayzhao as a reviewer in case he has a different opinion):
https://github.com/llvm/llvm-project/issues/61145 (backported to 16.x)
https://github.com/llvm/llvm-project/issues/62296 (backported to 16.x)
https://github.com/llvm/llvm-project/issues/62266 (not backported)
https://github.com/llvm/llvm-project/issues/61567 (not backported)

If we backport the two other issues to 16, then I think the changes in this review are fine. If we don't backport those two, I think we should claim Clang 17 to be conservative.

[ayzhao]

In D150122#4329401, @aaron.ballman wrote:

I believe we are having another release of Clang 16, but @tstellar can confirm or deny that.

AIUI, there were a few issues holding us back from claiming complete support (added @ayzhao as a reviewer in case he has a different opinion):
https://github.com/llvm/llvm-project/issues/61145 (backported to 16.x)
https://github.com/llvm/llvm-project/issues/62296 (backported to 16.x)
https://github.com/llvm/llvm-project/issues/62266 (not backported)
https://github.com/llvm/llvm-project/issues/61567 (not backported)

If we backport the two other issues to 16, then I think the changes in this review are fine. If we don't backport those two, I think we should claim Clang 17 to be conservative.

I started the backporting process for the remaining 2 bugs. I'm doing https://github.com/llvm/llvm-project/issues/62266 first before doing https://github.com/llvm/llvm-project/issues/61567 because otherwise there will be a merge issue. Once those two commits are backported then this patch LGTM.

[ayzhao]

Status update on backports:

• https://github.com/llvm/llvm-project/issues/62266 has been backported in https://github.com/llvm/llvm-project-release-prs/pull/441
• https://github.com/llvm/llvm-project/issues/61567 is still waiting on @shafik to approve https://github.com/llvm/llvm-project-release-prs/pull/446

[cor3ntin]

I guess we should land that now @erichkeane ?

[ayzhao]

In D150122#4388972, @cor3ntin wrote:

I guess we should land that now @erichkeane ?

Sorry, but there's actually one more crash that was just reported earlier this week: https://github.com/llvm/llvm-project/issues/63008. We should wait until the backport PR has been approved.

[ayzhao]

In D150122#4388978, @ayzhao wrote:

In D150122#4388972, @cor3ntin wrote:

I guess we should land that now @erichkeane ?

Sorry, but there's actually one more crash that was just reported earlier this week: https://github.com/llvm/llvm-project/issues/63008. We should wait until the backport PR has been approved.

That backport has just been merged, so this patch LGTM.

[erichkeane]

LGTM as well, thanks!

clang/www/cxx_status.html

<tr>
       <td rowspan="2" class="full" align="center">Yes</td>
     </tr>
       <tr>
         <td><a href="https://wg21.link/p1139r2">P1139R2</a></td>
       </tr>
     <tr>
       <td rowspan="2">Parenthesized initialization of aggregates</td>
       <td><a href="https://wg21.link/p0960r3">P0960R3</a></td>
-      <td rowspan="2" class="none" align="center">No</td>
+      <td rowspan="2" class="full" align="center">Clang 16</td>
     </tr>
       <tr> <!-- from Belfast -->
         <td><a href="https://wg21.link/p1975r0">P1975R0</a></td>
       </tr>
     <tr>
       <td rowspan="12">Modules</td>
       <td><a href="https://wg21.link/p1103r3">P1103R3</a></td>
       <td class="full" align="center">Clang 15</td>