This is an archive of the discontinued LLVM Phabricator instance.

[Clang] Fix status of P0960
ClosedPublic

Authored by cor3ntin on May 8 2023, 8:27 AM.

Details

Reviewers
ayzhao
erichkeane
Group Reviewers
Restricted Project
Commits
rG684f3c968d6b: [Clang] Fix status of P0960
Summary

P0960R3 and P1975R0 were marked not implemented because
of #61145,

This issue has been fixed and backported to LLVM 16,
the status page should reflect that.

Diff Detail

Event Timeline

cor3ntin created this revision.May 8 2023, 8:27 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 8 2023, 8:27 AM
cor3ntin requested review of this revision.May 8 2023, 8:27 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 8 2023, 8:27 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript

@aaron.ballman @erichkeane I'll merge that later today unless you see a reason not to.

erichkeane added a reviewer: Restricted Project.May 8 2023, 8:30 AM

I've got no problems with this. I'm a little suspicious of marking this done in clang-16 if this was done only at the end of the branch though? And do we know there is going to be another Clang 16 release?

I've got no problems with this. I'm a little suspicious of marking this done in clang-16 if this was done only at the end of the branch though? And do we know there is going to be another Clang 16 release?

Yes, I was asking myself the same question, I have no issue being conservative and saying 17 instead.

I've got no problems with this. I'm a little suspicious of marking this done in clang-16 if this was done only at the end of the branch though? And do we know there is going to be another Clang 16 release?

Yes, I was asking myself the same question, I have no issue being conservative and saying 17 instead.

Perhaps worth making Aaron make the decision :D

aaron.ballman added subscribers: ayzhao, tstellar.

I believe we are having another release of Clang 16, but @tstellar can confirm or deny that.

AIUI, there were a few issues holding us back from claiming complete support (added @ayzhao as a reviewer in case he has a different opinion):
https://github.com/llvm/llvm-project/issues/61145 (backported to 16.x)
https://github.com/llvm/llvm-project/issues/62296 (backported to 16.x)
https://github.com/llvm/llvm-project/issues/62266 (not backported)
https://github.com/llvm/llvm-project/issues/61567 (not backported)

If we backport the two other issues to 16, then I think the changes in this review are fine. If we don't backport those two, I think we should claim Clang 17 to be conservative.

I believe we are having another release of Clang 16, but @tstellar can confirm or deny that.

AIUI, there were a few issues holding us back from claiming complete support (added @ayzhao as a reviewer in case he has a different opinion):
https://github.com/llvm/llvm-project/issues/61145 (backported to 16.x)
https://github.com/llvm/llvm-project/issues/62296 (backported to 16.x)
https://github.com/llvm/llvm-project/issues/62266 (not backported)
https://github.com/llvm/llvm-project/issues/61567 (not backported)

If we backport the two other issues to 16, then I think the changes in this review are fine. If we don't backport those two, I think we should claim Clang 17 to be conservative.

I started the backporting process for the remaining 2 bugs. I'm doing https://github.com/llvm/llvm-project/issues/62266 first before doing https://github.com/llvm/llvm-project/issues/61567 because otherwise there will be a merge issue. Once those two commits are backported then this patch LGTM.

I guess we should land that now @erichkeane ?

ayzhao added a comment.Jun 1 2023, 2:54 PM

I guess we should land that now @erichkeane ?

Sorry, but there's actually one more crash that was just reported earlier this week: https://github.com/llvm/llvm-project/issues/63008. We should wait until the backport PR has been approved.

ayzhao accepted this revision.Jun 1 2023, 5:02 PM

I guess we should land that now @erichkeane ?

Sorry, but there's actually one more crash that was just reported earlier this week: https://github.com/llvm/llvm-project/issues/63008. We should wait until the backport PR has been approved.

That backport has just been merged, so this patch LGTM.

This revision is now accepted and ready to land.Jun 1 2023, 5:02 PM
erichkeane accepted this revision.Jun 2 2023, 6:20 AM

LGTM as well, thanks!

This revision was automatically updated to reflect the committed changes.