This is an archive of the discontinued LLVM Phabricator instance.

Differential D150077

[AArch64] Remove global constructors from AArch64Disassembler.cpp.
ClosedPublic

Authored by craig.topper on May 7 2023, 3:49 PM.

Details

Reviewers
c-rhodes
sdesmalen
paulwalker-arm
david-arm
kmclaughlin
Commits
rGc1d94ea08cd1: [AArch64] Remove global constructors from AArch64Disassembler.cpp.
Summary

Instead of using SmallVectors of SmallVectors, use a plain array.

Diff Detail

Event Timeline

craig.topper created this revision.May 7 2023, 3:49 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 7 2023, 3:49 PM
Herald added subscribers: hiraditya, kristof.beyls. · View Herald Transcript
craig.topper requested review of this revision.May 7 2023, 3:49 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 7 2023, 3:49 PM
Harbormaster completed remote builds in B230520: Diff 520216.May 7 2023, 4:38 PM
c-rhodes accepted this revision.May 9 2023, 1:33 AM
This revision is now accepted and ready to land.May 9 2023, 1:33 AM
Closed by commit rGc1d94ea08cd1: [AArch64] Remove global constructors from AArch64Disassembler.cpp. (authored by craig.topper). · Explain WhyMay 9 2023, 10:38 AM
This revision was automatically updated to reflect the committed changes.
craig.topper added a commit: rGc1d94ea08cd1: [AArch64] Remove global constructors from AArch64Disassembler.cpp..

Revision Contents

PathSize
llvm/
lib/
Target/
AArch64/
Disassembler/
21 lines

Diff 520751

llvm/lib/Target/AArch64/Disassembler/AArch64Disassembler.cpp

Show First 20 Lines • Show All 695 Lines • ▼ Show 20 LinesDecodeMatrixTileListRegisterClass(MCInst &Inst, unsigned RegMask,
uint64_t Address, uint64_t Address,
const MCDisassembler *Decoder) { const MCDisassembler *Decoder) {
if (RegMask > 0xFF) if (RegMask > 0xFF)
return Fail; return Fail;
Inst.addOperand(MCOperand::createImm(RegMask)); Inst.addOperand(MCOperand::createImm(RegMask));
return Success; return Success;
} }
static const SmallVector<SmallVector<unsigned, 16>, 5> static const MCPhysReg MatrixZATileDecoderTable[5][16] = {
MatrixZATileDecoderTable = {
{AArch64::ZAB0}, {AArch64::ZAB0},
{AArch64::ZAH0, AArch64::ZAH1}, {AArch64::ZAH0, AArch64::ZAH1},
{AArch64::ZAS0, AArch64::ZAS1, AArch64::ZAS2, AArch64::ZAS3}, {AArch64::ZAS0, AArch64::ZAS1, AArch64::ZAS2, AArch64::ZAS3},
{AArch64::ZAD0, AArch64::ZAD1, AArch64::ZAD2, AArch64::ZAD3, {AArch64::ZAD0, AArch64::ZAD1, AArch64::ZAD2, AArch64::ZAD3, AArch64::ZAD4,
AArch64::ZAD4, AArch64::ZAD5, AArch64::ZAD6, AArch64::ZAD7}, AArch64::ZAD5, AArch64::ZAD6, AArch64::ZAD7},
{AArch64::ZAQ0, AArch64::ZAQ1, AArch64::ZAQ2, AArch64::ZAQ3, {AArch64::ZAQ0, AArch64::ZAQ1, AArch64::ZAQ2, AArch64::ZAQ3, AArch64::ZAQ4,
AArch64::ZAQ4, AArch64::ZAQ5, AArch64::ZAQ6, AArch64::ZAQ7, AArch64::ZAQ5, AArch64::ZAQ6, AArch64::ZAQ7, AArch64::ZAQ8, AArch64::ZAQ9,
AArch64::ZAQ8, AArch64::ZAQ9, AArch64::ZAQ10, AArch64::ZAQ11, AArch64::ZAQ10, AArch64::ZAQ11, AArch64::ZAQ12, AArch64::ZAQ13,
AArch64::ZAQ12, AArch64::ZAQ13, AArch64::ZAQ14, AArch64::ZAQ15}}; AArch64::ZAQ14, AArch64::ZAQ15}};
template <unsigned NumBitsForTile> template <unsigned NumBitsForTile>
static DecodeStatus DecodeMatrixTile(MCInst &Inst, unsigned RegNo, static DecodeStatus DecodeMatrixTile(MCInst &Inst, unsigned RegNo,
uint64_t Address, uint64_t Address,
const MCDisassembler *Decoder) { const MCDisassembler *Decoder) {
unsigned LastReg = (1 << NumBitsForTile) - 1; unsigned LastReg = (1 << NumBitsForTile) - 1;
if (RegNo > LastReg) if (RegNo > LastReg)
return Fail; return Fail;
▲ Show 20 Lines • Show All 1,362 Lines • Show Last 20 Lines