[SystemZ][z/OS] Remove ENDRecord class from GOFF.h

[yusra.syeda]

Summary

ENDRecord class is no longer needed.

[Stoorx]

Why? Is it a piece of dead-code or it is never used (and surely will never be)?

Please provide some reasoning.

[yusra.syeda]

In D149895#4321169, @Stoorx wrote:

Why? Is it a piece of dead-code or it is never used (and surely will never be)?

Please provide some reasoning.

Yes, this is dead code.

[yusra.syeda]

ping :)

[kpn]

Why delete from class ENDRecord the support for having the entry point specified on the END card? Wouldn't that be useful in a dumping tool at least? Or is this handled somewhere else now?

[Everybody0523]

Anything the ENDRecord does can be easily handled by the parent Record class.

The ENDRecord class only has two functions, getNameLength is just a wrapper for get<T>() in the parent class (defined here) and getData() is likewise a basically just a wrapper for getContinuousData(), also defined in the parent class.

[kpn]

In D149895#4425105, @Everybody0523 wrote:

Anything the ENDRecord does can be easily handled by the parent Record class.

The ENDRecord class only has two functions, getNameLength is just a wrapper for get<T>() in the parent class (defined here) and getData() is likewise a basically just a wrapper for getContinuousData(), also defined in the parent class.

There are seven different fields in the END record. Having END cards be the only record type that requires callers to unpack the record manually doesn't seem like good design.

And the class is only dead because it hasn't been connected yet.

llvm/include/llvm/Object/GOFF.h

public:
   }
 
   static uint16_t getNameLength(const uint8_t *Record) {
     uint16_t Length;
     get<uint16_t>(Record, 70, Length);
     return Length;
   }
 };
-
-class ENDRecord : public Record {
-public:
-  static Error getData(const uint8_t *Record, SmallString<256> &CompleteData);
-
-  static uint16_t getNameLength(const uint8_t *Record) {
-    uint16_t Length;
-    get<uint16_t>(Record, 24, Length);
-    return Length;
-  }
-};
-
 } // end namespace object
 } // end namespace llvm
 
 #endif

llvm/lib/Object/GOFFObjectFile.cpp

Error HDRRecord::getData(const uint8_t *Record,
   return getContinuousData(Record, Length, 60, CompleteData);
 }
 
 Error ESDRecord::getData(const uint8_t *Record,
                          SmallString<256> &CompleteData) {
   uint16_t DataSize = getNameLength(Record);
   return getContinuousData(Record, DataSize, 72, CompleteData);
 }
-
-Error ENDRecord::getData(const uint8_t *Record,
-                         SmallString<256> &CompleteData) {
-  uint16_t Length = getNameLength(Record);
-  return getContinuousData(Record, Length, 26, CompleteData);
-}