This is an archive of the discontinued LLVM Phabricator instance.

[BPF][DebugInfo][NFC] Move BTF.h definitions from BPF target to DebugInfo
ClosedPublic

Authored by eddyz87 on Apr 28 2023, 4:42 PM.

Details

Summary

There are plans to add some BTF processing to tools like objdump and
readelf. This commit moves BTF.{h,def} files from BPF target specific
location to include/llvm/DebugInfo/* to avoid tools including headers
from lib/Target/*.

Diff Detail

Event Timeline

eddyz87 created this revision.Apr 28 2023, 4:42 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 28 2023, 4:42 PM
Herald added a subscriber: hiraditya. · View Herald Transcript
eddyz87 updated this revision to Diff 518487.May 1 2023, 10:32 AM

Changes to satisfy git-clang-format

eddyz87 published this revision for review.May 1 2023, 4:34 PM

Hi James, Fangrui,

Could you please take a look at this modification for DebugInfo headers?
It is a dependency for https://reviews.llvm.org/D149058 .

Herald added a project: Restricted Project. · View Herald TranscriptMay 1 2023, 4:34 PM
MaskRay accepted this revision.Jun 22 2023, 6:24 PM

Apologies for my slow response. This looks good to me, but you will need a stamp from the owner @yonghong-song

This revision is now accepted and ready to land.Jun 22 2023, 6:24 PM
yonghong-song accepted this revision.Jun 23 2023, 8:12 AM

LGTM. Thanks!