This is an archive of the discontinued LLVM Phabricator instance.

Differential D149469

[Flang] Add a missing case for bfloat
ClosedPublic

Authored by kiranchandramohan on Apr 28 2023, 10:42 AM.

Details

Reviewers
clementval
vzakhari
DavidTruby
sscalpone
Commits
rGb9aa3eb28cd9: [Flang] Add a missing case for bfloat
Summary

A case was missed for the bfloat type in the getRealType function
in FIRBuilder. This can cause a crash in some situations like in
the provided test. The patch adds the missing case.

Diff Detail

Event Timeline

kiranchandramohan created this revision.Apr 28 2023, 10:42 AM
Herald added a reviewer: sscalpone. · View Herald TranscriptApr 28 2023, 10:42 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald Transcript
Herald added subscribers: sunshaoce, mehdi_amini. · View Herald Transcript
kiranchandramohan requested review of this revision.Apr 28 2023, 10:42 AM
Herald added a subscriber: jdoerfert. · View Herald TranscriptApr 28 2023, 10:42 AM
vzakhari accepted this revision.Apr 28 2023, 10:45 AM

Thank you!

This revision is now accepted and ready to land.Apr 28 2023, 10:45 AM
Harbormaster completed remote builds in B228879: Diff 517988.Apr 28 2023, 11:39 AM
Closed by commit rGb9aa3eb28cd9: [Flang] Add a missing case for bfloat (authored by kiranchandramohan). · Explain WhyApr 28 2023, 11:39 AM
This revision was automatically updated to reflect the committed changes.
kiranchandramohan added a commit: rGb9aa3eb28cd9: [Flang] Add a missing case for bfloat.

Revision Contents

PathSize
flang/
lib/
Optimizer/
Builder/
2 lines
test/
Lower/
15 lines

Diff 518004

flang/lib/Optimizer/Builder/FIRBuilder.cpp

Show First 20 Lines • Show All 64 Lines • ▼ Show 20 Linesmlir::Type fir::FirOpBuilder::getVarLenSeqTy(mlir::Type eleTy, unsigned rank) {
fir::SequenceType::Shape shape(rank, fir::SequenceType::getUnknownExtent()); fir::SequenceType::Shape shape(rank, fir::SequenceType::getUnknownExtent());
return fir::SequenceType::get(shape, eleTy); return fir::SequenceType::get(shape, eleTy);
} }
mlir::Type fir::FirOpBuilder::getRealType(int kind) { mlir::Type fir::FirOpBuilder::getRealType(int kind) {
switch (kindMap.getRealTypeID(kind)) { switch (kindMap.getRealTypeID(kind)) {
case llvm::Type::TypeID::HalfTyID: case llvm::Type::TypeID::HalfTyID:
return mlir::FloatType::getF16(getContext()); return mlir::FloatType::getF16(getContext());
case llvm::Type::TypeID::BFloatTyID:
return mlir::FloatType::getBF16(getContext());
case llvm::Type::TypeID::FloatTyID: case llvm::Type::TypeID::FloatTyID:
return mlir::FloatType::getF32(getContext()); return mlir::FloatType::getF32(getContext());
case llvm::Type::TypeID::DoubleTyID: case llvm::Type::TypeID::DoubleTyID:
return mlir::FloatType::getF64(getContext()); return mlir::FloatType::getF64(getContext());
case llvm::Type::TypeID::X86_FP80TyID: case llvm::Type::TypeID::X86_FP80TyID:
return mlir::FloatType::getF80(getContext()); return mlir::FloatType::getF80(getContext());
case llvm::Type::TypeID::FP128TyID: case llvm::Type::TypeID::FP128TyID:
return mlir::FloatType::getF128(getContext()); return mlir::FloatType::getF128(getContext());
▲ Show 20 Lines • Show All 1,401 Lines • Show Last 20 Lines

flang/test/Lower/complex-real.f90

  • This file was added.
! RUN: bbc -emit-fir %s -o - | FileCheck %s
! RUN: %flang_fc1 -emit-fir %s -o - | FileCheck %s
! CHECK-LABEL: @_QPsb_complex_bfloat
! CHECK: %[[C_REF:.*]] = fir.alloca !fir.complex<3> {bindc_name = "c", uniq_name = "_QFsb_complex_bfloatEc"}
! CHECK: %[[R_REF:.*]] = fir.alloca bf16 {bindc_name = "r", uniq_name = "_QFsb_complex_bfloatEr"}
! CHECK: %[[R_VAL:.*]] = fir.load %[[R_REF]] : !fir.ref<bf16>
! CHECK: %[[C0:.*]] = arith.constant 0 : i32
! CHECK: %[[CREAL_REF:.*]] = fir.coordinate_of %[[C_REF]], %[[C0]] : (!fir.ref<!fir.complex<3>>, i32) -> !fir.ref<bf16>
! CHECK: fir.store %[[R_VAL]] to %[[CREAL_REF]] : !fir.ref<bf16>
subroutine sb_complex_bfloat
complex(kind=3) :: c
real(kind=3) :: r
c%re = r
end subroutine