This is an archive of the discontinued LLVM Phabricator instance.

Differential D149434

[PGO] Fix expensive test compilation error
ClosedPublic

Authored by Dinistro on Apr 28 2023, 2:54 AM.

Details

Reviewers
paquette
jroelofs
gysit
Commits
rG4030fff06ac1: [PGO] Fix expensive test compilation error
Summary

This commit fixes a compilation error introduced in
https://reviews.llvm.org/D149361

Diff Detail

Event Timeline

Dinistro created this revision.Apr 28 2023, 2:54 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 28 2023, 2:54 AM
Herald added subscribers: wlei, wenlei. · View Herald Transcript
Dinistro requested review of this revision.Apr 28 2023, 2:54 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 28 2023, 2:54 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B228776: Diff 517852.Apr 28 2023, 3:30 AM
Dinistro added a comment.Apr 28 2023, 3:38 AM

The build failure is related to a bug introduced in here: https://reviews.llvm.org/D149014

gysit accepted this revision.Apr 28 2023, 4:17 AM
gysit added a subscriber: gysit.

LGTM

This revision is now accepted and ready to land.Apr 28 2023, 4:17 AM
This revision was landed with ongoing or failed builds.Apr 28 2023, 5:17 AM
Closed by commit rG4030fff06ac1: [PGO] Fix expensive test compilation error (authored by Dinistro). · Explain Why
This revision was automatically updated to reflect the committed changes.
Dinistro added a commit: rG4030fff06ac1: [PGO] Fix expensive test compilation error.
Dinistro mentioned this in D149361: [profiling] Improve error message for raw profile header mismatches.Apr 28 2023, 5:19 AM

Revision Contents

PathSize
llvm/
unittests/
ProfileData/
10 lines

Diff 517879

llvm/unittests/ProfileData/InstrProfTest.cpp

Show First 20 Lines • Show All 1,350 Lines • ▼ Show 20 Lines
#if defined(_LP64) && defined(EXPENSIVE_CHECKS) #if defined(_LP64) && defined(EXPENSIVE_CHECKS)
TEST(ProfileReaderTest, ReadsLargeFiles) { TEST(ProfileReaderTest, ReadsLargeFiles) {
const size_t LargeSize = 1ULL << 32; // 4GB const size_t LargeSize = 1ULL << 32; // 4GB
auto RawProfile = WritableMemoryBuffer::getNewUninitMemBuffer(LargeSize); auto RawProfile = WritableMemoryBuffer::getNewUninitMemBuffer(LargeSize);
if (!RawProfile) if (!RawProfile)
GTEST_SKIP(); GTEST_SKIP();
auto RawProfileReaderOrErr = InstrProfReader::create(std::move(RawProfile)); auto RawProfileReaderOrErr = InstrProfReader::create(std::move(RawProfile));
ASSERT_TRUE(InstrProfError::take(RawProfileReaderOrErr.takeError()) == ASSERT_TRUE(
std::get<0>(InstrProfError::take(RawProfileReaderOrErr.takeError())) ==
instrprof_error::unrecognized_format); instrprof_error::unrecognized_format);
auto IndexedProfile = WritableMemoryBuffer::getNewUninitMemBuffer(LargeSize); auto IndexedProfile = WritableMemoryBuffer::getNewUninitMemBuffer(LargeSize);
if (!IndexedProfile) if (!IndexedProfile)
GTEST_SKIP(); GTEST_SKIP();
auto IndexedReaderOrErr = auto IndexedReaderOrErr =
IndexedInstrProfReader::create(std::move(IndexedProfile), nullptr); IndexedInstrProfReader::create(std::move(IndexedProfile), nullptr);
ASSERT_TRUE(InstrProfError::take(IndexedReaderOrErr.takeError()) == ASSERT_TRUE(
std::get<0>(InstrProfError::take(IndexedReaderOrErr.takeError())) ==
instrprof_error::bad_magic); instrprof_error::bad_magic);
} }
#endif #endif
} // end anonymous namespace } // end anonymous namespace