This is an archive of the discontinued LLVM Phabricator instance.

[ValueTracking] Add logic for `isKnownNonZero(ssub.sat X, Y)`
ClosedPublic

Authored by goldstein.w.n on Apr 27 2023, 11:20 PM.

Details

Summary

The logic here is the same for normal (sub X, Y), so just reused
isNonZeroSub.

Alive2 Link:

https://alive2.llvm.org/ce/z/9kSkMv

Diff Detail

Event Timeline

goldstein.w.n created this revision.Apr 27 2023, 11:20 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 27 2023, 11:20 PM
Herald added a subscriber: hiraditya. · View Herald Transcript
goldstein.w.n requested review of this revision.Apr 27 2023, 11:20 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 27 2023, 11:20 PM
nikic accepted this revision.Apr 28 2023, 5:46 AM

LGTM. It looks like we're missing the corresponding InstCombine for this: https://alive2.llvm.org/ce/z/hLC6aQ

This revision is now accepted and ready to land.Apr 28 2023, 5:46 AM

LGTM. It looks like we're missing the corresponding InstCombine for this: https://alive2.llvm.org/ce/z/hLC6aQ

Will post patch for that tomorrow.

LGTM. It looks like we're missing the corresponding InstCombine for this: https://alive2.llvm.org/ce/z/hLC6aQ

See: D149521