This is an archive of the discontinued LLVM Phabricator instance.

Differential D149416

[ValueTracking] Add logic for `isKnownNonZero(umin X, Y)`
ClosedPublic

Authored by goldstein.w.n on Apr 27 2023, 11:21 PM.

Details

Reviewers
StephenFan
nikic
spatel
Commits
rGe78c30a10fe7: [ValueTracking] Add logic for `isKnownNonZero(umin X, Y)`
Summary

(umin X, Y) != 0 -> X != 0 && Y != 0

Alive2 Link:

https://alive2.llvm.org/ce/z/AQh67i

Diff Detail

Event Timeline

goldstein.w.n created this revision.Apr 27 2023, 11:21 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 27 2023, 11:21 PM
Herald added a subscriber: hiraditya. · View Herald Transcript
goldstein.w.n requested review of this revision.Apr 27 2023, 11:21 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 27 2023, 11:21 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B228736: Diff 517800.Apr 27 2023, 11:21 PM
goldstein.w.n added a child revision: D149417: [ValueTracking] Add logic for `isKnownNonZero(smin/smax X, Y)`.Apr 27 2023, 11:27 PM
nikic accepted this revision.Apr 28 2023, 12:34 AM

LGTM

This revision is now accepted and ready to land.Apr 28 2023, 12:34 AM
goldstein.w.n added a parent revision: D149415: [ValueTracking] Add logic for `isKnownNonZero(umax X, Y)`.Apr 28 2023, 2:33 PM
goldstein.w.n updated this revision to Diff 518180.Apr 29 2023, 9:14 AM

Rebase

Harbormaster completed remote builds in B229021: Diff 518180.Apr 29 2023, 10:47 AM
goldstein.w.n updated this revision to Diff 518211.Apr 29 2023, 11:42 AM

Rebase

Harbormaster completed remote builds in B229047: Diff 518211.Apr 29 2023, 1:43 PM
goldstein.w.n updated this revision to Diff 518249.Apr 29 2023, 3:09 PM

Rebase

Harbormaster completed remote builds in B229081: Diff 518249.Apr 29 2023, 4:49 PM
Closed by commit rGe78c30a10fe7: [ValueTracking] Add logic for `isKnownNonZero(umin X, Y)` (authored by goldstein.w.n). · Explain WhyApr 30 2023, 8:07 AM
This revision was automatically updated to reflect the committed changes.
goldstein.w.n added a commit: rGe78c30a10fe7: [ValueTracking] Add logic for `isKnownNonZero(umin X, Y)`.

Revision Contents

PathSize
llvm/
lib/
Analysis/
3 lines
test/
Analysis/
ValueTracking/
10 lines

Diff 518325

llvm/lib/Analysis/ValueTracking.cpp

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 2,936 Lines • ▼ Show 20 Lines if (auto *II = dyn_cast<IntrinsicInst>(I)) {
II->getArgOperand(0), II->getArgOperand(1), II->getArgOperand(0), II->getArgOperand(1),
/*NSW*/ true); /*NSW*/ true);
case Intrinsic::umax: case Intrinsic::umax:
case Intrinsic::uadd_sat: case Intrinsic::uadd_sat:
if (isKnownNonZero(II->getArgOperand(0), DemandedElts, Depth, Q) || if (isKnownNonZero(II->getArgOperand(0), DemandedElts, Depth, Q) ||
isKnownNonZero(II->getArgOperand(1), DemandedElts, Depth, Q)) isKnownNonZero(II->getArgOperand(1), DemandedElts, Depth, Q))
return true; return true;
break; break;
case Intrinsic::umin:
return isKnownNonZero(II->getArgOperand(0), DemandedElts, Depth, Q) &&
isKnownNonZero(II->getArgOperand(1), DemandedElts, Depth, Q);
case Intrinsic::cttz: case Intrinsic::cttz:
return computeKnownBits(II->getArgOperand(0), DemandedElts, Depth, Q) return computeKnownBits(II->getArgOperand(0), DemandedElts, Depth, Q)
.Zero[0]; .Zero[0];
case Intrinsic::ctlz: case Intrinsic::ctlz:
return computeKnownBits(II->getArgOperand(0), DemandedElts, Depth, Q) return computeKnownBits(II->getArgOperand(0), DemandedElts, Depth, Q)
.isNonNegative(); .isNonNegative();
case Intrinsic::fshr: case Intrinsic::fshr:
case Intrinsic::fshl: case Intrinsic::fshl:
▲ Show 20 Lines • Show All 5,754 Lines • Show Last 20 Lines

llvm/test/Analysis/ValueTracking/known-non-zero.ll

Show First 20 Lines • Show All 988 Lines • ▼ Show 20 Lines
} }
define i1 @umin_nonzero(i8 %xx, i8 %yy, i8 %ind) { define i1 @umin_nonzero(i8 %xx, i8 %yy, i8 %ind) {
; CHECK-LABEL: @umin_nonzero( ; CHECK-LABEL: @umin_nonzero(
; CHECK-NEXT: [[X_NZ:%.*]] = icmp ne i8 [[XX:%.*]], 0 ; CHECK-NEXT: [[X_NZ:%.*]] = icmp ne i8 [[XX:%.*]], 0
; CHECK-NEXT: call void @llvm.assume(i1 [[X_NZ]]) ; CHECK-NEXT: call void @llvm.assume(i1 [[X_NZ]])
; CHECK-NEXT: [[Y_NZ:%.*]] = icmp ne i8 [[YY:%.*]], 0 ; CHECK-NEXT: [[Y_NZ:%.*]] = icmp ne i8 [[YY:%.*]], 0
; CHECK-NEXT: call void @llvm.assume(i1 [[Y_NZ]]) ; CHECK-NEXT: call void @llvm.assume(i1 [[Y_NZ]])
; CHECK-NEXT: [[X:%.*]] = call i8 @llvm.umin.i8(i8 [[XX]], i8 [[YY]]) ; CHECK-NEXT: ret i1 false
; CHECK-NEXT: [[Z:%.*]] = or i8 [[X]], [[IND:%.*]]
; CHECK-NEXT: [[R:%.*]] = icmp eq i8 [[Z]], 0
; CHECK-NEXT: ret i1 [[R]]
; ;
%x_nz = icmp ne i8 %xx, 0 %x_nz = icmp ne i8 %xx, 0
call void @llvm.assume(i1 %x_nz) call void @llvm.assume(i1 %x_nz)
%y_nz = icmp ne i8 %yy, 0 %y_nz = icmp ne i8 %yy, 0
call void @llvm.assume(i1 %y_nz) call void @llvm.assume(i1 %y_nz)
%x = call i8 @llvm.umin.i8(i8 %xx, i8 %yy) %x = call i8 @llvm.umin.i8(i8 %xx, i8 %yy)
%z = or i8 %x, %ind %z = or i8 %x, %ind
%r = icmp eq i8 %z, 0 %r = icmp eq i8 %z, 0
Show All 18 Lines
} }
define i1 @smin_nonzero(i8 %xx, i8 %yy, i8 %ind) { define i1 @smin_nonzero(i8 %xx, i8 %yy, i8 %ind) {
; CHECK-LABEL: @smin_nonzero( ; CHECK-LABEL: @smin_nonzero(
; CHECK-NEXT: [[X_NZ:%.*]] = icmp ne i8 [[XX:%.*]], 0 ; CHECK-NEXT: [[X_NZ:%.*]] = icmp ne i8 [[XX:%.*]], 0
; CHECK-NEXT: call void @llvm.assume(i1 [[X_NZ]]) ; CHECK-NEXT: call void @llvm.assume(i1 [[X_NZ]])
; CHECK-NEXT: [[Y_NZ:%.*]] = icmp ne i8 [[YY:%.*]], 0 ; CHECK-NEXT: [[Y_NZ:%.*]] = icmp ne i8 [[YY:%.*]], 0
; CHECK-NEXT: call void @llvm.assume(i1 [[Y_NZ]]) ; CHECK-NEXT: call void @llvm.assume(i1 [[Y_NZ]])
; CHECK-NEXT: [[X:%.*]] = call i8 @llvm.umin.i8(i8 [[XX]], i8 [[YY]]) ; CHECK-NEXT: ret i1 false
; CHECK-NEXT: [[Z:%.*]] = or i8 [[X]], [[IND:%.*]]
; CHECK-NEXT: [[R:%.*]] = icmp eq i8 [[Z]], 0
; CHECK-NEXT: ret i1 [[R]]
; ;
%x_nz = icmp ne i8 %xx, 0 %x_nz = icmp ne i8 %xx, 0
call void @llvm.assume(i1 %x_nz) call void @llvm.assume(i1 %x_nz)
%y_nz = icmp ne i8 %yy, 0 %y_nz = icmp ne i8 %yy, 0
call void @llvm.assume(i1 %y_nz) call void @llvm.assume(i1 %y_nz)
%x = call i8 @llvm.umin.i8(i8 %xx, i8 %yy) %x = call i8 @llvm.umin.i8(i8 %xx, i8 %yy)
%z = or i8 %x, %ind %z = or i8 %x, %ind
%r = icmp eq i8 %z, 0 %r = icmp eq i8 %z, 0
▲ Show 20 Lines • Show All 67 Lines • Show Last 20 Lines