This is an archive of the discontinued LLVM Phabricator instance.

[InstCombine] Add folds for `(icmp spred (ssub.sat X, Y), 0)` -> `X spred Y`
ClosedPublic

Authored by goldstein.w.n on Apr 29 2023, 10:39 AM.

Details

Summary

Alive2 links:

eq: https://alive2.llvm.org/ce/z/Fv3mvc
ne: https://alive2.llvm.org/ce/z/AEuEXU
sle: https://alive2.llvm.org/ce/z/mfKGUS
sge: https://alive2.llvm.org/ce/z/tX3_M4
sgt: https://alive2.llvm.org/ce/z/x7VgnZ
slt: https://alive2.llvm.org/ce/z/rQN4TM

Diff Detail

Event Timeline

goldstein.w.n created this revision.Apr 29 2023, 10:39 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 29 2023, 10:39 AM
goldstein.w.n requested review of this revision.Apr 29 2023, 10:39 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 29 2023, 10:39 AM
nikic requested changes to this revision.Apr 29 2023, 11:43 AM
nikic added inline comments.
llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp
3608

Shouldn't this be sle?

This revision now requires changes to proceed.Apr 29 2023, 11:43 AM
goldstein.w.n marked an inline comment as done.Apr 30 2023, 8:16 AM
nikic accepted this revision.Apr 30 2023, 9:46 AM

LGTM

This revision is now accepted and ready to land.Apr 30 2023, 9:46 AM