This is an archive of the discontinued LLVM Phabricator instance.

[tsan] Fix stack_sync_reuse.cc test on OS X
ClosedPublic

Authored by kubamracek on Nov 23 2015, 6:34 AM.

Details

Summary

The test relies on two variables in different frames to end up being on the same address. For some reason, this isn't true on OS X. This patch adds __attribute__((aligned(64))) to the variables, which actually makes the variables occupy the same address. This is still not a guarantee, but it's more likely to work (the test looks very fragile already).

Diff Detail

Event Timeline

kubamracek updated this revision to Diff 40923.Nov 23 2015, 6:34 AM
kubamracek retitled this revision from to [tsan] Fix stack_sync_reuse.cc test on OS X.
kubamracek updated this object.
kubamracek added reviewers: dvyukov, kcc, glider, samsonov.
dvyukov accepted this revision.Nov 23 2015, 6:46 AM
dvyukov edited edge metadata.
This revision is now accepted and ready to land.Nov 23 2015, 6:46 AM
This revision was automatically updated to reflect the committed changes.