Page MenuHomePhabricator

ismailp (Ismail Pazarbasi)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 18 2013, 1:35 PM (348 w, 1 d)

Recent Activity

Apr 19 2017

ismailp updated subscribers of D32251: Implement DR1601 - Promotion of enumeration with fixed underlying type.
Apr 19 2017, 3:41 PM
ismailp created D32251: Implement DR1601 - Promotion of enumeration with fixed underlying type.
Apr 19 2017, 3:37 PM

Sep 7 2016

ismailp added inline comments to D24158: Try contextually converting condition of constexpr if to Boolean value.
Sep 7 2016, 11:35 AM
ismailp committed rL280838: Try contextually converting condition of constexpr if to Boolean value.
Try contextually converting condition of constexpr if to Boolean value
Sep 7 2016, 11:33 AM
ismailp closed D24158: Try contextually converting condition of constexpr if to Boolean value by committing rL280838: Try contextually converting condition of constexpr if to Boolean value.
Sep 7 2016, 11:33 AM
ismailp added a comment to D24158: Try contextually converting condition of constexpr if to Boolean value.

Thank you for reviewing.

Sep 7 2016, 10:39 AM
ismailp updated the diff for D24158: Try contextually converting condition of constexpr if to Boolean value.
  • Added more tests
Sep 7 2016, 10:29 AM

Sep 1 2016

ismailp retitled D24158: Try contextually converting condition of constexpr if to Boolean value from to Try contextually converting condition of constexpr if to Boolean value.
Sep 1 2016, 2:26 PM

Nov 10 2015

ismailp added a comment to D9638: Implement `internal_start/join_thread` on Mac OS X.

Thanks to all for their time and reviewing the patch.

Nov 10 2015, 6:48 PM
ismailp committed rL252696: Implement `internal_start/join_thread` on Mac OS X.
Implement `internal_start/join_thread` on Mac OS X
Nov 10 2015, 6:46 PM
ismailp closed D9638: Implement `internal_start/join_thread` on Mac OS X by committing rL252696: Implement `internal_start/join_thread` on Mac OS X.
Nov 10 2015, 6:46 PM
ismailp added a comment to D14512: [tsan] Pass correct interposed function prefix to report function.

Thanks! Landed in r252695.

Nov 10 2015, 6:42 PM
ismailp committed rL252695: [tsan] Pass correct interposed function prefix to report function.
[tsan] Pass correct interposed function prefix to report function
Nov 10 2015, 6:41 PM
ismailp closed D14512: [tsan] Pass correct interposed function prefix to report function by committing rL252695: [tsan] Pass correct interposed function prefix to report function.
Nov 10 2015, 6:41 PM

Nov 9 2015

ismailp retitled D14512: [tsan] Pass correct interposed function prefix to report function from to [tsan] Pass correct interposed function prefix to report function.
Nov 9 2015, 1:11 PM
ismailp retitled D14510: [tsan] Implement `IsGlobalVar` for Darwin from to [tsan] Implement `IsGlobalVar` for Darwin.
Nov 9 2015, 1:00 PM
ismailp retitled D14509: Enable tsan-instrumented libcxx on Darwin from to Enable tsan-instrumented libcxx on Darwin.
Nov 9 2015, 12:27 PM
ismailp added a comment to D14486: [tsan] Skip building libcxx_tsan on OS X.

Hi Kuba,

Nov 9 2015, 7:11 AM

Nov 6 2015

ismailp added a comment to D14443: [tsan] Turn lit test deadlocks into failures (OS X).

I've go fork tests working by disabling interceptors for it. It's fused with another commit in my history, so I can't be precise. But...

Nov 6 2015, 9:30 AM
ismailp added a comment to rL251335: MismatchingNewDeleteDetector uses incorrect field, and finds no initializer.

Thanks!

Nov 6 2015, 4:37 AM · Restricted Project

Nov 2 2015

ismailp accepted D14233: [tsan] CMake support for TSan on OS X.

LGTM.

Nov 2 2015, 11:25 AM

Oct 26 2015

ismailp committed rL251335: MismatchingNewDeleteDetector uses incorrect field, and finds no initializer.
MismatchingNewDeleteDetector uses incorrect field, and finds no initializer
Oct 26 2015, 12:22 PM · Restricted Project
ismailp closed D9898: MismatchingNewDeleteDetector uses incorrect field, and finds no initializer by committing rL251335: MismatchingNewDeleteDetector uses incorrect field, and finds no initializer.
Oct 26 2015, 12:22 PM

Sep 30 2015

ismailp added inline comments to D12251: Analyzer: Calculate field offset correctly.
Sep 30 2015, 10:10 AM
ismailp updated the diff for D12251: Analyzer: Calculate field offset correctly.
  • Don't try to calculate field offset for Objective-C instance variables
  • Added test for Objective-C instance variables
  • Added a non-null pointer in test
Sep 30 2015, 9:59 AM

Sep 22 2015

ismailp added a comment to D12251: Analyzer: Calculate field offset correctly.

Ping!

Sep 22 2015, 3:27 PM
ismailp committed rL248314: Analyzer: Teach analyzer how to handle TypeTraitExpr.
Analyzer: Teach analyzer how to handle TypeTraitExpr
Sep 22 2015, 12:34 PM
ismailp closed D12482: Analyzer: Teach analyzer how to handle TypeTraitExpr by committing rL248314: Analyzer: Teach analyzer how to handle TypeTraitExpr.
Sep 22 2015, 12:34 PM
ismailp added a comment to D12482: Analyzer: Teach analyzer how to handle TypeTraitExpr.

Thanks for reviewing.

Sep 22 2015, 10:22 AM
ismailp updated the diff for D12482: Analyzer: Teach analyzer how to handle TypeTraitExpr.

Addressed comments.

Sep 22 2015, 10:20 AM

Sep 21 2015

ismailp added a comment to D12482: Analyzer: Teach analyzer how to handle TypeTraitExpr.

Sorry, that's a typo. It is 24170.

Sep 21 2015, 11:45 AM
ismailp added a comment to D12482: Analyzer: Teach analyzer how to handle TypeTraitExpr.

Ping!

Sep 21 2015, 8:07 AM

Sep 18 2015

ismailp added a reviewer for D9898: MismatchingNewDeleteDetector uses incorrect field, and finds no initializer: majnemer.

Ping!

Sep 18 2015, 3:48 PM
ismailp added a comment to D9638: Implement `internal_start/join_thread` on Mac OS X.

Ping!

Sep 18 2015, 2:59 PM
ismailp added a comment to D12119: Analyzer: Fix a crasher in UbigraphViz.

Thank you for reviewing!

Sep 18 2015, 2:57 PM
ismailp committed rL248050: Analyzer: Fix a crasher in UbigraphViz.
Analyzer: Fix a crasher in UbigraphViz
Sep 18 2015, 2:56 PM
ismailp closed D12119: Analyzer: Fix a crasher in UbigraphViz by committing rL248050: Analyzer: Fix a crasher in UbigraphViz.
Sep 18 2015, 2:56 PM
ismailp updated the diff for D12119: Analyzer: Fix a crasher in UbigraphViz.
  • Added a new test file instead of adding '-analyzer-viz-egraph-ubigraph' to an existing test.
Sep 18 2015, 2:50 PM

Sep 15 2015

ismailp added a comment to D12119: Analyzer: Fix a crasher in UbigraphViz.

I don't have ubigraph installed either. The purpose of the test isn't to check as to whether we can generate a conforming/sensible ubigraph output, but to ensure that this tiny patch works and clang doesn't crash. So, I'd keep it. But if you are worried about other/unknown problems in ubigraph generator that the test might surface, then we can proceed without the test, and a ubigraph expert can write an output validation test.

Sep 15 2015, 10:07 AM

Sep 11 2015

ismailp added a comment to D12251: Analyzer: Calculate field offset correctly.

Ping!

Sep 11 2015, 5:23 PM

Sep 7 2015

ismailp added a comment to D9898: MismatchingNewDeleteDetector uses incorrect field, and finds no initializer.

Ping! It seems like this patch was forgotten. This fixes PR24730, which is reported recently.

Sep 7 2015, 10:15 AM

Sep 4 2015

ismailp added a comment to D12119: Analyzer: Fix a crasher in UbigraphViz.

Thank you for the feedback! I have added the test in a C file, so we can get the first part of the patch in -- between lines 778-780.

Sep 4 2015, 3:04 PM
ismailp updated the diff for D12119: Analyzer: Fix a crasher in UbigraphViz.
  • Rolled back to the first version of patch, where only parameter Out is renamed to OutStream
  • Use a different test that doesn't trigger the self-loop assertion.
Sep 4 2015, 2:57 PM

Sep 3 2015

ismailp added a comment to D12119: Analyzer: Fix a crasher in UbigraphViz.

Ping!

Sep 3 2015, 1:43 PM

Aug 30 2015

ismailp retitled D12482: Analyzer: Teach analyzer how to handle TypeTraitExpr from to Analyzer: Teach analyzer how to handle TypeTraitExpr.
Aug 30 2015, 10:34 AM

Aug 22 2015

ismailp abandoned D11803: Teach `DlAddrSymbolizer::SymbolizeData` how to find symbol size.

OK, that makes sense. Thanks!

Aug 22 2015, 5:10 AM
ismailp added inline comments to D12119: Analyzer: Fix a crasher in UbigraphViz.
Aug 22 2015, 4:46 AM
ismailp updated the diff for D12119: Analyzer: Fix a crasher in UbigraphViz.
  • Change parameter name to OutStream.
Aug 22 2015, 4:39 AM

Aug 21 2015

ismailp retitled D12251: Analyzer: Calculate field offset correctly from to Analyzer: Calculate field offset correctly.
Aug 21 2015, 3:12 PM

Aug 20 2015

ismailp updated the diff for D12119: Analyzer: Fix a crasher in UbigraphViz.
  • Renamed Out parameter to Stm.
  • Removed assertion that checks whether an ExplodedNode has an edge to itself.
  • Added '-analyzer-viz-egraph-ubigraph' to an analyzer invocation in a test.
Aug 20 2015, 2:08 PM

Aug 18 2015

ismailp added inline comments to D12119: Analyzer: Fix a crasher in UbigraphViz.
Aug 18 2015, 3:52 PM
ismailp added inline comments to D12119: Analyzer: Fix a crasher in UbigraphViz.
Aug 18 2015, 3:06 PM
ismailp retitled D12119: Analyzer: Fix a crasher in UbigraphViz from to Analyzer: Fix a crasher in UbigraphViz.
Aug 18 2015, 3:01 PM

Aug 6 2015

ismailp retitled D11803: Teach `DlAddrSymbolizer::SymbolizeData` how to find symbol size from to Teach `DlAddrSymbolizer::SymbolizeData` how to find symbol size.
Aug 6 2015, 6:37 AM

Jul 24 2015

ismailp committed rL243151: __tsan::ThreadCreate takes incorrect value for detached argument.
__tsan::ThreadCreate takes incorrect value for detached argument
Jul 24 2015, 1:01 PM
ismailp closed D10606: __tsan::ThreadCreate takes incorrect value for detached argument by committing rL243151: __tsan::ThreadCreate takes incorrect value for detached argument.
Jul 24 2015, 1:01 PM
ismailp updated the diff for D9638: Implement `internal_start/join_thread` on Mac OS X.
  • Removed preprocessor directives guarding pthread.
Jul 24 2015, 12:57 PM

Jul 12 2015

ismailp added a comment to D10425: Warn, if parameter is used in ctor body after being used for move-construct.

A few thoughts - but probably having some review by rtreiu would be good. He's more involved in the diagnostic development than I am.

Have you run this over any substantial existing codebase to see what the stats are like (true/false positives, etc)?

No, I haven't, but I heard Google has a large C++11 codebase :) I saw this bug in clang's source code (I didn't submit patch for it yet, can do it in a few days).

Jul 12 2015, 4:51 AM

Jun 26 2015

ismailp added inline comments to D9638: Implement `internal_start/join_thread` on Mac OS X.
Jun 26 2015, 10:36 AM

Jun 23 2015

ismailp updated the diff for D10606: __tsan::ThreadCreate takes incorrect value for detached argument.

Removed PTHREAD_CREATE_JOINABLE definition.

Jun 23 2015, 10:07 AM

Jun 22 2015

ismailp retitled D10606: __tsan::ThreadCreate takes incorrect value for detached argument from to __tsan::ThreadCreate takes incorrect value for detached argument.
Jun 22 2015, 10:20 AM
ismailp updated the diff for D9638: Implement `internal_start/join_thread` on Mac OS X.

Allow only Mac OS X implementation of internal_start_thread and internal_join_thread

Jun 22 2015, 9:57 AM
ismailp added inline comments to D9638: Implement `internal_start/join_thread` on Mac OS X.
Jun 22 2015, 9:52 AM

Jun 12 2015

ismailp added a comment to D9898: MismatchingNewDeleteDetector uses incorrect field, and finds no initializer.

Ping.

Jun 12 2015, 3:55 PM
ismailp retitled D10425: Warn, if parameter is used in ctor body after being used for move-construct from to Warn, if parameter is used in ctor body after being used for move-construct.
Jun 12 2015, 3:53 PM

May 21 2015

ismailp updated the diff for D9898: MismatchingNewDeleteDetector uses incorrect field, and finds no initializer.

Return from analyzeInClassInitializer, if in-class initializer is null.

May 21 2015, 1:06 PM

May 20 2015

ismailp retitled D9898: MismatchingNewDeleteDetector uses incorrect field, and finds no initializer from to MismatchingNewDeleteDetector uses incorrect field, and finds no initializer.
May 20 2015, 3:46 PM

May 18 2015

ismailp committed rL237613: Added missing 'override' to `ReadMismatchingDeleteExpressions`.
Added missing 'override' to `ReadMismatchingDeleteExpressions`
May 18 2015, 1:50 PM
ismailp committed rL237608: Detect uses of mismatching forms of 'new' and 'delete'.
Detect uses of mismatching forms of 'new' and 'delete'
May 18 2015, 1:03 PM

May 14 2015

ismailp added a comment to D4661: Detect mismatching 'new' and 'delete' uses.

Thank you for reviewing!

May 14 2015, 10:41 AM
ismailp committed rL237368: Detect uses of mismatching forms of 'new' and 'delete'.
Detect uses of mismatching forms of 'new' and 'delete'
May 14 2015, 9:19 AM
ismailp closed D4661: Detect mismatching 'new' and 'delete' uses by committing rL237368: Detect uses of mismatching forms of 'new' and 'delete'.
May 14 2015, 9:18 AM

May 13 2015

ismailp added inline comments to D9638: Implement `internal_start/join_thread` on Mac OS X.
May 13 2015, 12:06 PM

May 12 2015

ismailp committed rL237190: Include missing 'sanitizer_platform_limits_posix.h'.
Include missing 'sanitizer_platform_limits_posix.h'
May 12 2015, 2:34 PM
ismailp committed rL237177: Call system's sigfillset and sigprocmask functions from sanitizers.
Call system's sigfillset and sigprocmask functions from sanitizers
May 12 2015, 2:00 PM
ismailp closed D9637: Call system's sigfillset and sigprocmask functions from sanitizers by committing rL237177: Call system's sigfillset and sigprocmask functions from sanitizers.
May 12 2015, 2:00 PM
ismailp added a comment to D9636: Sanitizers: Implement `GetRSS` on Mac OS X.

Thank you both for your time!

May 12 2015, 1:51 PM
ismailp committed rL237173: Sanitizers: Implement `GetRSS` on Mac OS X.
Sanitizers: Implement `GetRSS` on Mac OS X
May 12 2015, 1:50 PM
ismailp closed D9636: Sanitizers: Implement `GetRSS` on Mac OS X by committing rL237173: Sanitizers: Implement `GetRSS` on Mac OS X.
May 12 2015, 1:50 PM
ismailp updated the diff for D9636: Sanitizers: Implement `GetRSS` on Mac OS X.
  • Sort includes alphabetically
  • Remove newline in GetRSS
May 12 2015, 1:49 PM

May 11 2015

ismailp updated the diff for D9636: Sanitizers: Implement `GetRSS` on Mac OS X.

Addressed comments.

May 11 2015, 1:30 PM

May 10 2015

ismailp committed rL236951: SanitizerCoverage: Use `createSanitizerCtor` to create ctor and call init.
SanitizerCoverage: Use `createSanitizerCtor` to create ctor and call init
May 10 2015, 6:49 AM

May 9 2015

ismailp added a comment to D9638: Implement `internal_start/join_thread` on Mac OS X.

Hi Alexander,

May 9 2015, 2:19 PM
ismailp retitled D9638: Implement `internal_start/join_thread` on Mac OS X from to Implement `internal_start/join_thread` on Mac OS X.
May 9 2015, 9:31 AM
ismailp retitled D9637: Call system's sigfillset and sigprocmask functions from sanitizers from to Call system's sigfillset and sigprocmask functions from sanitizers.
May 9 2015, 8:11 AM
ismailp retitled D9636: Sanitizers: Implement `GetRSS` on Mac OS X from to Sanitizers: Implement `GetRSS` on Mac OS X.
May 9 2015, 8:01 AM

May 7 2015

ismailp committed rL236786: Revert "SanitizerCoverage: Use `createSanitizerCtor` to create ctor and call….
Revert "SanitizerCoverage: Use `createSanitizerCtor` to create ctor and call…
May 7 2015, 3:21 PM
ismailp committed rL236781: When checking msan.module_ctor, use CHECK-LABEL instead of CHECK.
When checking msan.module_ctor, use CHECK-LABEL instead of CHECK
May 7 2015, 2:51 PM
ismailp committed rL236780: SanitizerCoverage: Use `createSanitizerCtor` to create ctor and call init.
SanitizerCoverage: Use `createSanitizerCtor` to create ctor and call init
May 7 2015, 2:46 PM
ismailp closed D8780: SanitizerCoverage: Use `createSanitizerCtor` to create ctor and call init by committing rL236780: SanitizerCoverage: Use `createSanitizerCtor` to create ctor and call init.
May 7 2015, 2:46 PM
ismailp committed rL236779: MSan: Use `createSanitizerCtor` to create ctor, and call `__msan_init`.
MSan: Use `createSanitizerCtor` to create ctor, and call `__msan_init`
May 7 2015, 2:45 PM
ismailp closed D8781: MSan: Use `createSanitizerCtor` to create ctor, and call `__msan_init` by committing rL236779: MSan: Use `createSanitizerCtor` to create ctor, and call `__msan_init`.
May 7 2015, 2:45 PM
ismailp committed rL236778: TSan: Use `createSanitizerCtor` to create ctor, and call `__tsan_init`.
TSan: Use `createSanitizerCtor` to create ctor, and call `__tsan_init`
May 7 2015, 2:45 PM
ismailp closed D8779: TSan: Use `createSanitizerCtor` to create ctor, and call `__tsan_init` by committing rL236778: TSan: Use `createSanitizerCtor` to create ctor, and call `__tsan_init`.
May 7 2015, 2:45 PM
ismailp committed rL236777: ASan: Use `createSanitizerCtor` to create ctor, and call `__asan_init`.
ASan: Use `createSanitizerCtor` to create ctor, and call `__asan_init`
May 7 2015, 2:44 PM
ismailp closed D8778: ASan: Use `createSanitizerCtor` to create ctor, and call `__asan_init` by committing rL236777: ASan: Use `createSanitizerCtor` to create ctor, and call `__asan_init`.
May 7 2015, 2:44 PM
ismailp added a comment to D8780: SanitizerCoverage: Use `createSanitizerCtor` to create ctor and call init.

Thank you for your time, and feedback.

May 7 2015, 2:37 PM
ismailp updated the diff for D8781: MSan: Use `createSanitizerCtor` to create ctor, and call `__msan_init`.
  • createSanitizerCtor renamed to createSanitizerCtorAndInitFunctions to match with changes in D8777
  • Added simple check to ensure MSan's ctor is added to module ctors, and __msan_init is called from ctor
May 7 2015, 2:16 PM
ismailp updated the diff for D8780: SanitizerCoverage: Use `createSanitizerCtor` to create ctor and call init.
  • createSanitizerCtor renamed to createSanitizerCtorAndInitFunctions to match with changes in D8777
  • SanCovModuleInit was initialized with checkInterfaceFunction by mistake; this is already done by createSanitizerCtorAndInitFunctions
May 7 2015, 1:39 PM

May 6 2015

ismailp updated the diff for D8778: ASan: Use `createSanitizerCtor` to create ctor, and call `__asan_init`.

Updated after changes in D8777;

  • createSanitizerCtor renamed to createSanitizerCtorAndInitFunctions to match with changes in D8777
  • Added simple check to ensure ASan's ctor is added to module ctors, and __asan_init_v5 is called from ctor
May 6 2015, 3:11 PM