This is an archive of the discontinued LLVM Phabricator instance.

[tsan] Mark a few more tests with "UNSUPPORTED: darwin"
ClosedPublic

Authored by kubamracek on Nov 23 2015, 6:23 AM.

Details

Summary

There's a few more lit tests that require features not available on OS X (pthrea spinlocks, MAP_32BIT, pthread_setname_np), let's mark them with "UNSUPPORTED: darwin".

Diff Detail

Event Timeline

kubamracek updated this revision to Diff 40921.Nov 23 2015, 6:23 AM
kubamracek retitled this revision from to [tsan] Mark a few more tests with "UNSUPPORTED: darwin".
kubamracek updated this object.
kubamracek added reviewers: dvyukov, kcc, glider, samsonov.
dvyukov added inline comments.Nov 23 2015, 7:48 AM
test/tsan/mutexset6.cc
5

Please change pthread_spinlock_t to pthread_mutex_t. This is a good test and it does not really need spinlock.

kubamracek updated this revision to Diff 41036.Nov 24 2015, 5:51 AM

Updating patch (keeping mutexset6.cc as it is, will update it in a different revision).

dvyukov accepted this revision.Nov 28 2015, 1:20 AM
dvyukov edited edge metadata.
This revision is now accepted and ready to land.Nov 28 2015, 1:20 AM
This revision was automatically updated to reflect the committed changes.