This is an archive of the discontinued LLVM Phabricator instance.

Differential D149184

[AMDGPU] Delete test for illegal v_cndmask_b16_dpp
ClosedPublic

Authored by Joe_Nash on Apr 25 2023, 1:13 PM.

Details

Reviewers
critson
foad
kosarev
Commits
rGf8ec7a0944ae: [AMDGPU] Delete test for illegal v_cndmask_b16_dpp
Summary

There are no VOP2 or VOP2 with dpp forms of v_cndmask_b16. Delete the
test. NFC.

Diff Detail

Event Timeline

Joe_Nash created this revision.Apr 25 2023, 1:13 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 25 2023, 1:13 PM
Herald added subscribers: StephenFan, kerbowa, tpr and 4 others. · View Herald Transcript
Joe_Nash requested review of this revision.Apr 25 2023, 1:13 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 25 2023, 1:13 PM
Herald added subscribers: llvm-commits, wdng. · View Herald Transcript
Harbormaster completed remote builds in B228077: Diff 516875.Apr 25 2023, 1:49 PM
critson accepted this revision.Apr 25 2023, 5:27 PM

LGTM

This revision is now accepted and ready to land.Apr 25 2023, 5:27 PM
This revision was landed with ongoing or failed builds.Apr 26 2023, 6:51 AM
Closed by commit rGf8ec7a0944ae: [AMDGPU] Delete test for illegal v_cndmask_b16_dpp (authored by Joe_Nash). · Explain Why
This revision was automatically updated to reflect the committed changes.
Joe_Nash added a commit: rGf8ec7a0944ae: [AMDGPU] Delete test for illegal v_cndmask_b16_dpp.

Revision Contents

PathSize
llvm/
test/
CodeGen/
AMDGPU/
14 lines

Diff 517158

llvm/test/CodeGen/AMDGPU/valu-mask-write-hazard.mir

Show First 20 Lines • Show All 129 Lines • ▼ Show 20 Lines bb.0:
; GCN-NEXT: S_WAITCNT_DEPCTR 65534 ; GCN-NEXT: S_WAITCNT_DEPCTR 65534
; GCN-NEXT: S_ENDPGM 0 ; GCN-NEXT: S_ENDPGM 0
$vgpr0 = V_CNDMASK_B32_e64_dpp $vgpr0, 0, $vgpr1, 0, $vgpr2, $sgpr2_sgpr3, 1, 15, 15, 1, implicit $exec $vgpr0 = V_CNDMASK_B32_e64_dpp $vgpr0, 0, $vgpr1, 0, $vgpr2, $sgpr2_sgpr3, 1, 15, 15, 1, implicit $exec
$sgpr2_sgpr3 = S_CSELECT_B64 -1, 0, implicit $scc $sgpr2_sgpr3 = S_CSELECT_B64 -1, 0, implicit $scc
S_ENDPGM 0 S_ENDPGM 0
... ...
--- ---
name: mask_hazard_cndmask_dpp3
body: |
bb.0:
; GCN-LABEL: name: mask_hazard_cndmask_dpp3
; GCN: $vgpr0 = V_CNDMASK_B16_dpp $vgpr0, 0, $vgpr1, 0, $vgpr2, 1, 15, 15, 1, implicit $vcc, implicit $exec
; GCN-NEXT: $vcc = S_CSELECT_B64 -1, 0, implicit $scc
; GCN-NEXT: S_WAITCNT_DEPCTR 65534
; GCN-NEXT: S_ENDPGM 0
$vgpr0 = V_CNDMASK_B16_dpp $vgpr0, 0, $vgpr1, 0, $vgpr2, 1, 15, 15, 1, implicit $vcc, implicit $exec
$vcc = S_CSELECT_B64 -1, 0, implicit $scc
S_ENDPGM 0
...
---
name: mask_hazard_cndmask_dpp4 name: mask_hazard_cndmask_dpp4
body: | body: |
bb.0: bb.0:
; GCN-LABEL: name: mask_hazard_cndmask_dpp4 ; GCN-LABEL: name: mask_hazard_cndmask_dpp4
; GCN: $vgpr0 = V_CNDMASK_B16_e64_dpp $vgpr0, 0, $vgpr1, 0, $vgpr2, $sgpr2_sgpr3, 1, 15, 15, 1, implicit $exec ; GCN: $vgpr0 = V_CNDMASK_B16_e64_dpp $vgpr0, 0, $vgpr1, 0, $vgpr2, $sgpr2_sgpr3, 1, 15, 15, 1, implicit $exec
; GCN-NEXT: $sgpr2_sgpr3 = S_CSELECT_B64 -1, 0, implicit $scc ; GCN-NEXT: $sgpr2_sgpr3 = S_CSELECT_B64 -1, 0, implicit $scc
; GCN-NEXT: S_WAITCNT_DEPCTR 65534 ; GCN-NEXT: S_WAITCNT_DEPCTR 65534
; GCN-NEXT: S_ENDPGM 0 ; GCN-NEXT: S_ENDPGM 0
▲ Show 20 Lines • Show All 401 Lines • Show Last 20 Lines