On OS X, we don't have pthread spinlocks, let's just use a regular mutex instead. Secondly, pthread_rwlock_t is much larger (200 bytes), so char padding_[64 - sizeof(pthread_rwlock_t)] actually underflows.
Details
Details
Diff Detail
Diff Detail
Paths
| Differential D14862
[tsan] Fix deadlock_detector_stress_test.cc testcase for OS X ClosedPublic Authored by kubamracek on Nov 20 2015, 1:38 AM.
Details Summary On OS X, we don't have pthread spinlocks, let's just use a regular mutex instead. Secondly, pthread_rwlock_t is much larger (200 bytes), so char padding_[64 - sizeof(pthread_rwlock_t)] actually underflows.
Diff Detail Event Timelinekubamracek retitled this revision from to [tsan] Fix deadlock_detector_stress_test.cc testcase for OS X. kubamracek updated this object. This revision is now accepted and ready to land.Nov 20 2015, 1:55 AM Closed by commit rL253659: [tsan] Fix deadlock_detector_stress_test.cc testcase for OS X (authored by kuba.brecka). · Explain WhyNov 20 2015, 3:16 AM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 40749 test/tsan/deadlock_detector_stress_test.cc
|