This is an archive of the discontinued LLVM Phabricator instance.

[clang-format] Fix regression with AlignTrailingComments set to true
ClosedPublic

Authored by owenpan on Apr 15 2023, 8:14 PM.

Details

Summary

In D132131, OverEmptyLines was set to 1 for AlignTrailingComments.Kind and caused a regression if AlignTrailingComments was explicitly set to true.

Fixes https://github.com/llvm/llvm-project/issues/62161.

Diff Detail

Event Timeline

owenpan created this revision.Apr 15 2023, 8:14 PM
Herald added projects: Restricted Project, Restricted Project, Restricted Project. · View Herald TranscriptApr 15 2023, 8:14 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
owenpan requested review of this revision.Apr 15 2023, 8:14 PM
owenpan edited the summary of this revision. (Show Details)
MyDeveloperDay accepted this revision.Apr 16 2023, 3:38 AM

If this was the functionality pre 16 then LGTM

This revision is now accepted and ready to land.Apr 16 2023, 3:38 AM
This revision was landed with ongoing or failed builds.Apr 16 2023, 6:52 PM
This revision was automatically updated to reflect the committed changes.

If this was the functionality pre 16 then LGTM

Yep.