In D132131, OverEmptyLines was set to 1 for AlignTrailingComments.Kind and caused a regression if AlignTrailingComments was explicitly set to true.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Paths
| Differential D148447
[clang-format] Fix regression with AlignTrailingComments set to true ClosedPublic Authored by owenpan on Apr 15 2023, 8:14 PM.
Details Summary In D132131, OverEmptyLines was set to 1 for AlignTrailingComments.Kind and caused a regression if AlignTrailingComments was explicitly set to true.
Diff Detail
Event TimelineHerald added projects: Restricted Project, Restricted Project, Restricted Project. · View Herald TranscriptApr 15 2023, 8:14 PM This revision is now accepted and ready to land.Apr 16 2023, 3:38 AM This revision was landed with ongoing or failed builds.Apr 16 2023, 6:52 PM Closed by commit rG2bcfff6708d2: [clang-format] Fix regression with AlignTrailingComments set to true (authored by owenpan). · Explain Why This revision was automatically updated to reflect the committed changes. Comment Actions
Yep.
Revision Contents
Diff 514074 clang/lib/Format/Format.cpp
clang/unittests/Format/ConfigParseTest.cpp
|