Page MenuHomePhabricator

yusuke-kadowaki (Yusuke Kadowaki)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 17 2022, 6:46 AM (15 w, 4 d)

Recent Activity

Thu, Dec 1

yusuke-kadowaki added a comment to D139029: [clang-format] Don't move comments if AlignTrailingComments: Kind: Leave .

@mairacanal
Thank you for the catch!

Thu, Dec 1, 6:59 AM · Restricted Project, Restricted Project, Restricted Project

Nov 1 2022

yusuke-kadowaki added a comment to D137075: [clang-format] Fix document of AlignTrailingComments.

Thank you.
Please land when you have time.

Nov 1 2022, 5:35 AM · Restricted Project, Restricted Project

Oct 31 2022

yusuke-kadowaki updated the diff for D137075: [clang-format] Fix document of AlignTrailingComments.

Add a blankline after the endcode to deal with the Buildbot error.
https://lab.llvm.org/buildbot/#/builders/92/builds/34906

Oct 31 2022, 5:32 AM · Restricted Project, Restricted Project
yusuke-kadowaki published D137075: [clang-format] Fix document of AlignTrailingComments for review.
Oct 31 2022, 5:04 AM · Restricted Project, Restricted Project

Oct 29 2022

yusuke-kadowaki added a comment to D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines.

Could you land this please if we are not waiting for anything?

Oct 29 2022, 9:42 PM · Restricted Project, Restricted Project, Restricted Project

Oct 18 2022

yusuke-kadowaki added a comment to D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines.

Please provide a name and an email so someone could commit it on your behalf

Oct 18 2022, 6:43 AM · Restricted Project, Restricted Project, Restricted Project
yusuke-kadowaki added a comment to D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines.

Thank you for all the reviews. Appreciate it.

Oct 18 2022, 6:00 AM · Restricted Project, Restricted Project, Restricted Project

Oct 15 2022

yusuke-kadowaki updated the diff for D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines.
  • Rebased
  • Remove more braces
  • Update rst
Oct 15 2022, 6:48 AM · Restricted Project, Restricted Project, Restricted Project

Oct 13 2022

yusuke-kadowaki updated the diff for D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines.

Added more tests
Removed braces

Oct 13 2022, 6:27 AM · Restricted Project, Restricted Project, Restricted Project

Oct 10 2022

yusuke-kadowaki added inline comments to D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines.
Oct 10 2022, 7:47 AM · Restricted Project, Restricted Project, Restricted Project
yusuke-kadowaki updated the diff for D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines.

Implment trailing comments Leave option

Oct 10 2022, 7:44 AM · Restricted Project, Restricted Project, Restricted Project

Sep 15 2022

yusuke-kadowaki added inline comments to D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines.
Sep 15 2022, 7:52 AM · Restricted Project, Restricted Project, Restricted Project
yusuke-kadowaki added inline comments to D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines.
Sep 15 2022, 7:42 AM · Restricted Project, Restricted Project, Restricted Project
yusuke-kadowaki updated the diff for D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines.

Implementation done except for the Leave option.

Sep 15 2022, 7:42 AM · Restricted Project, Restricted Project, Restricted Project

Sep 12 2022

yusuke-kadowaki added a comment to D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines.

So other than the naming, does the struct look good?

Sep 12 2022, 10:03 AM · Restricted Project, Restricted Project, Restricted Project

Sep 10 2022

yusuke-kadowaki added a comment to D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines.

Thank you for the detailed explanation. I understood the needs for unsigned OverEmptyLines field.
Please review the struct definition first. Then I'll implement the rest of the code.

Sep 10 2022, 10:14 AM · Restricted Project, Restricted Project, Restricted Project
yusuke-kadowaki updated the diff for D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines.

Just updated the Style struct field definitions for review. Haven't implemented the logics.

Sep 10 2022, 10:06 AM · Restricted Project, Restricted Project, Restricted Project

Sep 8 2022

yusuke-kadowaki added inline comments to D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines.
Sep 8 2022, 8:40 AM · Restricted Project, Restricted Project, Restricted Project

Sep 7 2022

yusuke-kadowaki added inline comments to D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines.
Sep 7 2022, 5:49 AM · Restricted Project, Restricted Project, Restricted Project

Sep 6 2022

yusuke-kadowaki added inline comments to D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines.
Sep 6 2022, 8:08 AM · Restricted Project, Restricted Project, Restricted Project
yusuke-kadowaki updated the diff for D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines.
  • Introduce new struct
  • Update document
Sep 6 2022, 8:07 AM · Restricted Project, Restricted Project, Restricted Project

Sep 5 2022

yusuke-kadowaki added inline comments to D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines.
Sep 5 2022, 7:15 AM · Restricted Project, Restricted Project, Restricted Project
yusuke-kadowaki updated the diff for D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines.
  • Change to use verifyFormat
Sep 5 2022, 7:15 AM · Restricted Project, Restricted Project, Restricted Project
yusuke-kadowaki added a comment to D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines.

Can we all agree with the decision whether we use the AlignConsecutiveStyle or introduce a new struct before I start implementing or updating the document?
IMO, both are reasonable in some respects so I'd like you owners to decide.

Sep 5 2022, 6:07 AM · Restricted Project, Restricted Project, Restricted Project

Sep 4 2022

yusuke-kadowaki added inline comments to D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines.
Sep 4 2022, 8:14 AM · Restricted Project, Restricted Project, Restricted Project
yusuke-kadowaki updated the diff for D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines.
  • Revert doc
  • Revert rst as well
  • Apply format
  • Update implementation to deal with the setting of MaxEmptyLinesToKeep
  • Add test for the combination with MaxEmptyLinesToKeep
Sep 4 2022, 8:14 AM · Restricted Project, Restricted Project, Restricted Project

Sep 1 2022

yusuke-kadowaki added inline comments to D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines.
Sep 1 2022, 9:07 AM · Restricted Project, Restricted Project, Restricted Project
yusuke-kadowaki updated the diff for D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines.
  • Update tests
  • Fix document
Sep 1 2022, 8:54 AM · Restricted Project, Restricted Project, Restricted Project

Aug 31 2022

yusuke-kadowaki added inline comments to D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines.
Aug 31 2022, 6:21 AM · Restricted Project, Restricted Project, Restricted Project
yusuke-kadowaki updated the diff for D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines.
  • Remove trailing whitespace
  • Update document
Aug 31 2022, 6:20 AM · Restricted Project, Restricted Project, Restricted Project

Aug 30 2022

yusuke-kadowaki added inline comments to D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines.
Aug 30 2022, 7:24 AM · Restricted Project, Restricted Project, Restricted Project
yusuke-kadowaki updated the diff for D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines.
  • Fix the newline condition
  • Update tests
Aug 30 2022, 7:23 AM · Restricted Project, Restricted Project, Restricted Project

Aug 25 2022

yusuke-kadowaki updated the diff for D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines.
  • Remove my comments
  • Update documentation
  • Sort
Aug 25 2022, 7:31 AM · Restricted Project, Restricted Project, Restricted Project

Aug 23 2022

yusuke-kadowaki added inline comments to D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines.
Aug 23 2022, 9:01 AM · Restricted Project, Restricted Project, Restricted Project
yusuke-kadowaki updated the diff for D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines.
  • Port AlignTrailingComments to one of the members of AlignConsecutiveStyle
  • Add documentation
  • Move tests to FormatTestComments
  • Add more tests
    • I left some failing tests that I think we should add implementations to make them pass. That's because I wanted to get some reviews for the work I've done so far before tackling on it.
Aug 23 2022, 8:51 AM · Restricted Project, Restricted Project, Restricted Project

Aug 18 2022

yusuke-kadowaki published D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines for review.
Aug 18 2022, 6:21 AM · Restricted Project, Restricted Project, Restricted Project