[compiler-rt] [test] [asan] Mark the static tests unsupported on mingw

[mstorsjo]

Summary

It turns out that googletest unit tests don't react to the
config.unsupported flag so far, so we need to change the framework
for that. (Such a change should be split out to a separate commit,
but I'm including it here for now, for complete overview of this
change.)

The symbol referenced in the non-dynamic case for i386,
_except_handler4, isn't available in mingw configurations (where
we only ever link the dynamic CRT); for ASAN_DYNAMIC, the symbol is
redirected to _except_handler4_common which does exist.

When the static asan testsuites are marked as unsupported (but
available), building check-compiler-rt or check-asan ends up
trying to link the unit tests for the static ccase even if they're
not going to be executed; therefore, this practically irrelevant
case still needs to be compileable and linkable.

This is an alternative to D148319, and depends on D148442.

[mstorsjo]

@alvinhochun What do you think about this, compared to D148319? (This would need to be split up into separate pieces reviewed separately though...)

[vitalybuka]

llvm/utils/lit/lit/formats/googletest.py

31

you should move this file into a separate patch
and include a test

[vitalybuka]

I assume this needs a rebase?

[mstorsjo]

In D148443#4366388, @vitalybuka wrote:

I assume this needs a rebase?

As D148319 was accepted, this one isn't strictly needed. Parts of it might be useful to split out and upstream separately anyway though, so I've left it without closing, but haven't had time to prioritize that bit yet...

compiler-rt/lib/asan/asan_win.cpp

void InitializePlatformInterceptors() {
 
   ASAN_INTERCEPT_FUNC(CreateThread);
   ASAN_INTERCEPT_FUNC(SetUnhandledExceptionFilter);
 
 #ifdef _WIN64
   ASAN_INTERCEPT_FUNC(__C_specific_handler);
 #else
   ASAN_INTERCEPT_FUNC(_except_handler3);
+#if ASAN_DYNAMIC || !defined(__MINGW32__)
   ASAN_INTERCEPT_FUNC(_except_handler4);
 #endif
+#endif
 
   // Try to intercept kernel32!RaiseException, and if that fails, intercept
   // ntdll!RtlRaiseException instead.
   if (!::__interception::OverrideFunction("RaiseException",
                                           (uptr)WRAP(RaiseException),
                                           (uptr *)&REAL(RaiseException))) {
     CHECK(::__interception::OverrideFunction("RtlRaiseException",
                                              (uptr)WRAP(RtlRaiseException),

compiler-rt/test/asan/Unit/lit.site.cfg.py.in

if @ASAN_TEST_DYNAMIC@:
   test_dir = "@CONFIG_NAME_DYNAMIC@"
 else:
   test_dir = "@CONFIG_NAME@"
 config.test_exec_root = os.path.join("@COMPILER_RT_BINARY_DIR@",
                                      "lib", "asan", "tests", test_dir)
 
 config.test_source_root = config.test_exec_root
 
+target_is_msvc = bool(re.match(r'.*-windows-msvc$', config.target_triple))
+if config.host_os == 'Windows' and not @ASAN_TEST_DYNAMIC@ and not target_is_msvc:
+  config.unsupported = True
+
 # When LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=on, the initial value of
 # config.compiler_rt_libdir (COMPILER_RT_RESOLVED_LIBRARY_OUTPUT_DIR) has the
 # host triple as the trailing path component. The value is incorrect for i386
 # tests on x86_64 hosts and vice versa. Adjust config.compiler_rt_libdir
 # accordingly.
 if config.enable_per_target_runtime_dir and config.target_arch != config.host_arch:
     if config.target_arch == 'i386':
         config.compiler_rt_libdir = re.sub(r'/x86_64(?=-[^/]+$)', '/i386', config.compiler_rt_libdir)
     elif config.target_arch == 'x86_64':
         config.compiler_rt_libdir = re.sub(r'/i386(?=-[^/]+$)', '/x86_64', config.compiler_rt_libdir)
 
 # Set LD_LIBRARY_PATH to pick dynamic runtime up properly.
 push_ld_library_path(config, config.compiler_rt_libdir)
 
 if not config.parallelism_group:
   config.parallelism_group = 'shadow-memory'

compiler-rt/test/asan/lit.cfg.py

else:
   config.substitutions.append(('%fPIC', '-fPIC'))
   config.substitutions.append(('%fPIE', '-fPIE'))
   config.substitutions.append(('%pie', '-pie'))
 
 # Only run the tests on supported OSs.
 if config.host_os not in ['Linux', 'Darwin', 'FreeBSD', 'SunOS', 'Windows', 'NetBSD']:
   config.unsupported = True
 
+if config.host_os == 'Windows' and not config.asan_dynamic and not target_is_msvc:
+  config.unsupported = True
+
 if not config.parallelism_group:
   config.parallelism_group = 'shadow-memory'
 
 if config.host_os == 'NetBSD':
   config.substitutions.insert(0, ('%run', config.netbsd_noaslr_prefix))

llvm/utils/lit/lit/formats/googletest.py

def __init__(self, test_sub_dirs, test_suffix, run_under = []):
         if kIsWindows:
             exe_suffix += '.exe'
 
         # Also check for .py files for testing purposes.
         self.test_suffixes = {exe_suffix, test_suffix + '.py'}
         self.run_under = run_under
 
     def get_num_tests(self, path, litConfig, localConfig):
+        if localConfig.unsupported:
+            return 0
+
         list_test_cmd = self.prepareCmd(
             [path, '--gtest_list_tests', '--gtest_filter=-*DISABLED_*'])
         try:
             out = subprocess.check_output(list_test_cmd,
                                           env=localConfig.environment)
         except subprocess.CalledProcessError as exc:
             litConfig.warning(
                 "unable to discover google-tests in %r: %s. Process output: %s"
def execute(self, test, litConfig):
         cmd = [testPath]
         cmd = self.prepareCmd(cmd)
         if litConfig.useValgrind:
             cmd = litConfig.valgrindArgs + cmd
 
         if litConfig.noExecute:
             return lit.Test.PASS, ''
 
+        if test.config.unsupported:
+            return lit.Test.UNSUPPORTED, ''
+
         def get_shard_header(shard_env):
             shard_envs = ' '.join([k + '=' + v for k, v in shard_env.items()])
             return f"Script(shard):\n--\n%s %s\n--\n" % (shard_envs, ' '.join(cmd))
 
         shard_header = get_shard_header(shard_env)
 
         try:
             out, _, exitCode = lit.util.executeCommand(