[compiler-rt] [test] [asan] Skip the static asan testsuites on mingw targets

[mstorsjo]

Summary

Mingw only provides a dynamically linked CRT (contrary to
MSVC/clang-cl), so it is expected that the static asan test
configuration doesn't work.

Skip adding these test suites in mingw configurations.

[alvinhochun]

Originally I was thinking of just marking the test as unsupported in compiler-rt\test\asan\lit.cfg.py.

Looking through CMakeLists.txt the change seems quite confusing. Why does the suspicious looking variable COMPILER_RT_ASAN_HAS_STATIC_RUNTIME not work, and why does it guard the dynamic asan tests instead of the static asan tests that we have to do the opposite of what it does for MINGW?

[mstorsjo]

In D148319#4271087, @alvinhochun wrote:

Originally I was thinking of just marking the test as unsupported in compiler-rt\test\asan\lit.cfg.py.

Yes, that was my initial thought also, but then when I started looking around how these test suites were set up, I realized that this actually was kinda straightforward (in one sense). I later did try to do it that way too, but it had a couple complications. I can post the patches for that anyway, for comparisons.

Looking through CMakeLists.txt the change seems quite confusing. Why does the suspicious looking variable COMPILER_RT_ASAN_HAS_STATIC_RUNTIME not work, and why does it guard the dynamic asan tests instead of the static asan tests that we have to do the opposite of what it does for MINGW?

Yeah that variable seems quite surprisingly named compared to the rest, but I kinda don't want to try to untangle that...

[vitalybuka]

In D148319#4271537, @mstorsjo wrote:

In D148319#4271087, @alvinhochun wrote:

Originally I was thinking of just marking the test as unsupported in compiler-rt\test\asan\lit.cfg.py.

Yes, that was my initial thought also, but then when I started looking around how these test suites were set up, I realized that this actually was kinda straightforward (in one sense). I later did try to do it that way too, but it had a couple complications. I can post the patches for that anyway, for comparisons.

Looking through CMakeLists.txt the change seems quite confusing. Why does the suspicious looking variable COMPILER_RT_ASAN_HAS_STATIC_RUNTIME not work, and why does it guard the dynamic asan tests instead of the static asan tests that we have to do the opposite of what it does for MINGW?

Yeah that variable seems quite surprisingly named compared to the rest, but I kinda don't want to try to untangle that...

Maybe this will help https://reviews.llvm.org/rG969902b43b0c028d49dba8ee0b443351fa0453cb

[alvinhochun]

Since @vitalybuka already approved this, I think this is fine for now, probably no need for D148443.

compiler-rt/test/asan/CMakeLists.txt

foreach(arch ${ASAN_TEST_ARCH})
   get_test_cc_for_arch(${arch} ASAN_TEST_TARGET_CC ASAN_TEST_TARGET_CFLAGS)
   if(ANDROID OR APPLE)
     set(ASAN_TEST_DYNAMIC True)
   else()
     set(ASAN_TEST_DYNAMIC False)
   endif()
   string(TOUPPER ${arch} ARCH_UPPER_CASE)
   set(CONFIG_NAME ${ARCH_UPPER_CASE}${OS_NAME}Config)
+  if(NOT MINGW)
+    # MinGW environments don't provide a statically linked CRT, so only the
+    # dynamic asan test configuration can be expected to work.
     configure_lit_site_cfg(
       ${CMAKE_CURRENT_SOURCE_DIR}/lit.site.cfg.py.in
       ${CMAKE_CURRENT_BINARY_DIR}/${CONFIG_NAME}/lit.site.cfg.py
       )
     list(APPEND ASAN_TESTSUITES ${CMAKE_CURRENT_BINARY_DIR}/${CONFIG_NAME})
+  endif()
 
   if(COMPILER_RT_ASAN_HAS_STATIC_RUNTIME)
     string(TOLOWER "-${arch}-${OS_NAME}-dynamic" ASAN_TEST_CONFIG_SUFFIX)
     set(ASAN_TEST_DYNAMIC True)
     set(CONFIG_NAME ${ARCH_UPPER_CASE}${OS_NAME}DynamicConfig)
     configure_lit_site_cfg(
       ${CMAKE_CURRENT_SOURCE_DIR}/lit.site.cfg.py.in
       ${CMAKE_CURRENT_BINARY_DIR}/${CONFIG_NAME}/lit.site.cfg.py)

 
 # Add unit tests.
 if(COMPILER_RT_INCLUDE_TESTS)
   foreach(arch ${ASAN_TEST_ARCH})
     string(TOUPPER ${arch} ARCH_UPPER_CASE)
     set(CONFIG_NAME ${ARCH_UPPER_CASE}${OS_NAME}Config)
     set(CONFIG_NAME_DYNAMIC ${ARCH_UPPER_CASE}${OS_NAME}DynamicConfig)
 
+    if(NOT MINGW)
+      # MinGW environments don't provide a statically linked CRT, so only the
+      # dynamic asan test configuration can be expected to work.
       set(ASAN_TEST_DYNAMIC False)
       configure_lit_site_cfg(
         ${CMAKE_CURRENT_SOURCE_DIR}/Unit/lit.site.cfg.py.in
         ${CMAKE_CURRENT_BINARY_DIR}/Unit/${CONFIG_NAME}/lit.site.cfg.py)
+    endif()
     if(COMPILER_RT_ASAN_HAS_STATIC_RUNTIME)
       set(ASAN_TEST_DYNAMIC True)
       configure_lit_site_cfg(
         ${CMAKE_CURRENT_SOURCE_DIR}/Unit/lit.site.cfg.py.in
         ${CMAKE_CURRENT_BINARY_DIR}/Unit/${CONFIG_NAME_DYNAMIC}/lit.site.cfg.py)
     endif()
     # FIXME: support unit test in the android test runner
     if (NOT ANDROID)
+      if (NOT MINGW)
         list(APPEND ASAN_TEST_DEPS AsanUnitTests)
         list(APPEND ASAN_TESTSUITES ${CMAKE_CURRENT_BINARY_DIR}/Unit/${CONFIG_NAME})
+      endif()
       if(COMPILER_RT_ASAN_HAS_STATIC_RUNTIME)
         list(APPEND ASAN_DYNAMIC_TEST_DEPS AsanDynamicUnitTests)
         list(APPEND ASAN_DYNAMIC_TESTSUITES ${CMAKE_CURRENT_BINARY_DIR}/Unit/${CONFIG_NAME_DYNAMIC})
       endif()
     endif()
   endforeach()
 endif()