This is an archive of the discontinued LLVM Phabricator instance.

Differential D148442

[compiler-rt] [test] Don't override config.unsupported in TestCases/Windows
ClosedPublic

Authored by mstorsjo on Apr 15 2023, 3:06 PM.

Details

Reviewers
vitalybuka
alvinhochun
Commits
rG073e7f25f359: [compiler-rt] [test] Don't override config.unsupported in TestCases/Windows
Summary

This is a leftover from when these tests were added in
2bdca2006941a3a7de8e16ea9af9a758b367ee32 in 2014 (when the toplevel
asan/lit.cfg set "config.unsupported = True" on Windows). When the
common tests were included on Windows in
89d994367a597134fa7e1724314044e217718165 in 2015, that commit should
have removed the now unnecessary "config.unsupported = False" line here.

Diff Detail

Event Timeline

mstorsjo created this revision.Apr 15 2023, 3:06 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 15 2023, 3:06 PM
Herald added subscribers: Enna1, dberris. · View Herald Transcript
mstorsjo requested review of this revision.Apr 15 2023, 3:06 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 15 2023, 3:06 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
mstorsjo added a child revision: D148443: [compiler-rt] [test] [asan] Mark the static tests unsupported on mingw.Apr 15 2023, 3:13 PM
Harbormaster completed remote builds in B225877: Diff 513942.Apr 15 2023, 3:26 PM
mstorsjo added a comment.Apr 19 2023, 3:45 AM

Ping; this should be a rather straightforward cleanup of a leftover override.

alvinhochun accepted this revision.Apr 19 2023, 5:53 AM

LGTM

This revision is now accepted and ready to land.Apr 19 2023, 5:53 AM
Closed by commit rG073e7f25f359: [compiler-rt] [test] Don't override config.unsupported in TestCases/Windows (authored by mstorsjo). · Explain WhyApr 19 2023, 9:23 AM
This revision was automatically updated to reflect the committed changes.
mstorsjo added a commit: rG073e7f25f359: [compiler-rt] [test] Don't override config.unsupported in TestCases/Windows.
vitalybuka added a comment.Apr 19 2023, 10:52 AM

LGTM

Revision Contents

PathSize
compiler-rt/
test/
asan/
TestCases/
Windows/
7 lines

Diff 514989

compiler-rt/test/asan/TestCases/Windows/lit.local.cfg.py

def getRoot(config): def getRoot(config):
if not config.parent: if not config.parent:
return config return config
return getRoot(config.parent) return getRoot(config.parent)
root = getRoot(config) root = getRoot(config)
# We only run a small set of tests on Windows for now. if root.host_os not in ['Windows']:
# Override the parent directory's "unsupported" decision until we can handle
# all of its tests.
if root.host_os in ['Windows']:
config.unsupported = False
else:
config.unsupported = True config.unsupported = True