This is an archive of the discontinued LLVM Phabricator instance.

Differential D148177

[Clang][AIX] Remove error for -fprofile-instr-generate/use on AIX
ClosedPublic

Authored by ZarkoCA on Apr 12 2023, 3:24 PM.

Details

Reviewers
w2yehia
qiongsiwu1
hubert.reinterpretcast
Commits
rG8a39465d0015: [Clang][AIX] Remove error for -fprofile-instr-generate/use on AIX
Summary

Instrumented profiling now works on AIX and there is no dependency
on LTO for PGO. Remove the error.

Diff Detail

Event Timeline

ZarkoCA created this revision.Apr 12 2023, 3:24 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 12 2023, 3:24 PM
Herald added subscribers: wlei, wenlei. · View Herald Transcript
ZarkoCA requested review of this revision.Apr 12 2023, 3:24 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 12 2023, 3:24 PM
Herald added subscribers: cfe-commits, MaskRay. · View Herald Transcript
Harbormaster completed remote builds in B225193: Diff 512984.Apr 12 2023, 4:23 PM
qiongsiwu1 accepted this revision.Apr 13 2023, 11:35 AM

LGTM! Thanks!

This revision is now accepted and ready to land.Apr 13 2023, 11:35 AM
This revision was landed with ongoing or failed builds.Apr 20 2023, 8:08 AM
Closed by commit rG8a39465d0015: [Clang][AIX] Remove error for -fprofile-instr-generate/use on AIX (authored by ZarkoCA). · Explain Why
This revision was automatically updated to reflect the committed changes.
ZarkoCA added a commit: rG8a39465d0015: [Clang][AIX] Remove error for -fprofile-instr-generate/use on AIX.
ZarkoCA mentioned this in D148960: [Clang][AIX] Add back error for -fprofile-sample-generate/use on AIX.Apr 21 2023, 2:06 PM
ZarkoCA mentioned this in rG951919e5112c: [Clang][AIX] Add back error for -fprofile-sample-generate/use on AIX.Apr 26 2023, 11:55 AM

Revision Contents

PathSize
clang/
lib/
Driver/
ToolChains/
9 lines
test/
Driver/
8 lines

Diff 515339

clang/lib/Driver/ToolChains/Clang.cpp

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 734 Lines • ▼ Show 20 Lines D.Diag(diag::err_drv_argument_not_allowed_with)
<< ProfileGenerateArg->getSpelling() << ProfileUseArg->getSpelling(); << ProfileGenerateArg->getSpelling() << ProfileUseArg->getSpelling();
if (CSPGOGenerateArg && PGOGenerateArg) { if (CSPGOGenerateArg && PGOGenerateArg) {
D.Diag(diag::err_drv_argument_not_allowed_with) D.Diag(diag::err_drv_argument_not_allowed_with)
<< CSPGOGenerateArg->getSpelling() << PGOGenerateArg->getSpelling(); << CSPGOGenerateArg->getSpelling() << PGOGenerateArg->getSpelling();
PGOGenerateArg = nullptr; PGOGenerateArg = nullptr;
} }
if (TC.getTriple().isOSAIX()) {
if (ProfileGenerateArg)
D.Diag(diag::err_drv_unsupported_opt_for_target)
<< ProfileGenerateArg->getSpelling() << TC.getTriple().str();
if (Arg *ProfileSampleUseArg = getLastProfileSampleUseArg(Args))
D.Diag(diag::err_drv_unsupported_opt_for_target)
<< ProfileSampleUseArg->getSpelling() << TC.getTriple().str();
}
if (ProfileGenerateArg) { if (ProfileGenerateArg) {
if (ProfileGenerateArg->getOption().matches( if (ProfileGenerateArg->getOption().matches(
options::OPT_fprofile_instr_generate_EQ)) options::OPT_fprofile_instr_generate_EQ))
CmdArgs.push_back(Args.MakeArgString(Twine("-fprofile-instrument-path=") + CmdArgs.push_back(Args.MakeArgString(Twine("-fprofile-instrument-path=") +
ProfileGenerateArg->getValue())); ProfileGenerateArg->getValue()));
// The default is to use Clang Instrumentation. // The default is to use Clang Instrumentation.
CmdArgs.push_back("-fprofile-instrument=clang"); CmdArgs.push_back("-fprofile-instrument=clang");
if (TC.getTriple().isWindowsMSVCEnvironment()) { if (TC.getTriple().isWindowsMSVCEnvironment()) {
▲ Show 20 Lines • Show All 7,770 Lines • Show Last 20 Lines

clang/test/Driver/unsupported-option.c

// RUN: not %clang %s --hedonism -### 2>&1 | \ // RUN: not %clang %s --hedonism -### 2>&1 | \
// RUN: FileCheck %s // RUN: FileCheck %s
// CHECK: error: unsupported option '--hedonism' // CHECK: error: unsupported option '--hedonism'
// RUN: not %clang %s --hell -### 2>&1 | \ // RUN: not %clang %s --hell -### 2>&1 | \
// RUN: FileCheck %s --check-prefix=DID-YOU-MEAN // RUN: FileCheck %s --check-prefix=DID-YOU-MEAN
// DID-YOU-MEAN: error: unsupported option '--hell'; did you mean '--help'? // DID-YOU-MEAN: error: unsupported option '--hell'; did you mean '--help'?
// RUN: not %clang -fprofile-instr-generate --target=powerpc-ibm-aix %s 2>&1 | \
// RUN: FileCheck %s --check-prefix=INVALID-AIX-PROFILE
// INVALID-AIX-PROFILE: error: unsupported option '-fprofile-instr-generate' for target
// RUN: not %clang -fprofile-sample-use=code.prof --target=powerpc-ibm-aix %s 2>&1 | \
// RUN: FileCheck %s --check-prefix=AIX-PROFILE-SAMPLE
// AIX-PROFILE-SAMPLE: error: unsupported option '-fprofile-sample-use=' for target
// RUN: not %clang --target=powerpc-ibm-aix %s -mlong-double-128 2>&1 | \ // RUN: not %clang --target=powerpc-ibm-aix %s -mlong-double-128 2>&1 | \
// RUN: FileCheck %s --check-prefix=AIX-LONGDOUBLE128-ERR // RUN: FileCheck %s --check-prefix=AIX-LONGDOUBLE128-ERR
// AIX-LONGDOUBLE128-ERR: error: unsupported option '-mlong-double-128' for target 'powerpc-ibm-aix' // AIX-LONGDOUBLE128-ERR: error: unsupported option '-mlong-double-128' for target 'powerpc-ibm-aix'
// RUN: not %clang --target=powerpc64-ibm-aix %s -mlong-double-128 2>&1 | \ // RUN: not %clang --target=powerpc64-ibm-aix %s -mlong-double-128 2>&1 | \
// RUN: FileCheck %s --check-prefix=AIX64-LONGDOUBLE128-ERR // RUN: FileCheck %s --check-prefix=AIX64-LONGDOUBLE128-ERR
// AIX64-LONGDOUBLE128-ERR: error: unsupported option '-mlong-double-128' for target 'powerpc64-ibm-aix' // AIX64-LONGDOUBLE128-ERR: error: unsupported option '-mlong-double-128' for target 'powerpc64-ibm-aix'