This is an archive of the discontinued LLVM Phabricator instance.

[libunwind] [test] Mark the signal_frame test as unsupported on Windows
ClosedPublic

Authored by mstorsjo on Apr 8 2023, 1:05 PM.

Details

Summary

Mark it as unsupported on x86_64, arm and aarch64. On i686, DWARF
is used as the default unwinding format, and there, the CFI
directives are supported.

I'm not sure if it's worth to keep the complex regex to allow the
test to be run on i686 - we could also just mark it unsupported on
all windows variants.

Diff Detail

Event Timeline

mstorsjo created this revision.Apr 8 2023, 1:05 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptApr 8 2023, 1:05 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
mstorsjo requested review of this revision.Apr 8 2023, 1:05 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 8 2023, 1:05 PM
cdavis5x accepted this revision.Apr 8 2023, 1:25 PM
phosek accepted this revision.Apr 8 2023, 2:05 PM

LGTM

This revision is now accepted and ready to land.Apr 8 2023, 2:05 PM
MaskRay accepted this revision.Apr 9 2023, 7:42 PM
This revision was landed with ongoing or failed builds.Apr 10 2023, 2:03 PM
This revision was automatically updated to reflect the committed changes.