This is an archive of the discontinued LLVM Phabricator instance.

[flang][openacc] Add missing piece to translate to LLVM IR dialect
ClosedPublic

Authored by clementval on Apr 7 2023, 4:38 PM.

Diff Detail

Event Timeline

clementval created this revision.Apr 7 2023, 4:38 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptApr 7 2023, 4:38 PM
clementval requested review of this revision.Apr 7 2023, 4:38 PM

Looks good. I just have a few concerns about the UnrealizedConversionCastOp handling.

flang/lib/Optimizer/CodeGen/CodeGen.cpp
3654

Should you assert there is a single output?

3660–3666

This should possibly not be commented out.

PeteSteinfeld requested changes to this revision.Apr 7 2023, 8:17 PM

I'm seeing errors when I try to build with this patch that are similar to the ones I saw when reviewing D147825.

This revision now requires changes to proceed.Apr 7 2023, 8:17 PM

address review comments

PeteSteinfeld accepted this revision.Apr 10 2023, 10:12 AM

All builds and tests correctly and looks good.

This revision is now accepted and ready to land.Apr 10 2023, 10:12 AM
razvanlupusoru accepted this revision.Apr 10 2023, 12:03 PM