This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU][Global-ISel] reuse extension related patterns
ClosedPublic

Authored by shchenz on Apr 7 2023, 3:34 AM.

Details

Summary

With the change in the td file, there will be new rules for extension related patterns in AMDGPU global isel MatchTable.

But we can not use these patterns in global isel for now as there seems some bug/limitation in selectImpl(), the select function will create an illegal copy from VGPR to SGPR.

So this patch also tries not to use these new added rules for now. So these two changes make this patch be an NFC. I think this is expected.
This patch is needed because of many other rules in D141247.

Fixes #61468

Diff Detail

Event Timeline

shchenz created this revision.Apr 7 2023, 3:34 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 7 2023, 3:34 AM
shchenz requested review of this revision.Apr 7 2023, 3:34 AM
shchenz edited the summary of this revision. (Show Details)Apr 7 2023, 3:35 AM
arsenm accepted this revision.Apr 7 2023, 4:05 PM

Can you file a new issue to remove the workaround?

This revision is now accepted and ready to land.Apr 7 2023, 4:05 PM

Can you file a new issue to remove the workaround?

Thanks for your continuous help @arsenm. https://github.com/llvm/llvm-project/issues/62035 is filed.