This tries to remove all cases where we repeat the instruction name as
both an identifier (the tablegen name) and as a string (the assembler/
disassembler name). It uses tablegen's new !tolower operator.
Details
Details
- Reviewers
dp - Group Reviewers
Restricted Project - Commits
- rG939fbef3ea2e: [AMDGPU] Reduce repetition in SMEM instruction definitions
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
More of that would be great.
llvm/lib/Target/AMDGPU/SMInstructions.td | ||
---|---|---|
347–349 | nit: These spaces after < here and below might need some more treatment. |
llvm/lib/Target/AMDGPU/SMInstructions.td | ||
---|---|---|
347–349 | Whoops. Fixed in 6b6303ac0024. |
nit: These spaces after < here and below might need some more treatment.