This is an archive of the discontinued LLVM Phabricator instance.

[symbolizer] Build 'Request' object in single point. NFC
ClosedPublic

Authored by sepavloff on Mar 28 2023, 11:20 PM.

Details

Summary

All control paths in executeCommand create Request object for use in
calls to 'print' function and do it identically. With this change the
Request object is created in a single point, which simplifies changing
implementation of Request class.

This is a prerequisite patch for implementation of symbol+offset lookup.

Diff Detail

Event Timeline

sepavloff created this revision.Mar 28 2023, 11:20 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 28 2023, 11:20 PM
sepavloff requested review of this revision.Mar 28 2023, 11:20 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 28 2023, 11:20 PM
This revision is now accepted and ready to land.Mar 29 2023, 12:15 AM
This revision was landed with ongoing or failed builds.Mar 30 2023, 7:28 AM
This revision was automatically updated to reflect the committed changes.