This is an archive of the discontinued LLVM Phabricator instance.

[mlir][sparse] convert a sparse tensor slice to sparse tensor correctly.
ClosedPublic

Authored by Peiming on Mar 28 2023, 12:54 PM.

Diff Detail

Event Timeline

Peiming created this revision.Mar 28 2023, 12:54 PM
Herald added a project: Restricted Project. · View Herald Transcript
Peiming requested review of this revision.Mar 28 2023, 12:54 PM
Peiming updated this revision to Diff 509106.Mar 28 2023, 12:56 PM

minor fixes.

aartbik added inline comments.Mar 28 2023, 12:59 PM
mlir/lib/Dialect/SparseTensor/Transforms/SparseTensorCodegen.cpp
1064

space after closing )

1065

add comment on slice properties (of source and dest)

1066–1068

Cannot

wrengr added inline comments.Mar 28 2023, 1:01 PM
mlir/lib/Dialect/SparseTensor/Transforms/SparseTensorCodegen.cpp
1064

You should leave the space there

1066–1068

Does ConvertOp::verify actually guarantee this condition? If not, then this should be a failure or emitError rather than an assert

Peiming updated this revision to Diff 509119.Mar 28 2023, 1:41 PM
Peiming marked 5 inline comments as done.

address comments.

aartbik accepted this revision.Mar 28 2023, 1:48 PM
This revision is now accepted and ready to land.Mar 28 2023, 1:48 PM
This revision was landed with ongoing or failed builds.Mar 28 2023, 2:39 PM
This revision was automatically updated to reflect the committed changes.