Page MenuHomePhabricator
Differential D147074

[mlir][sparse] convert a sparse tensor slice to sparse tensor correctly.
ClosedPublic
Actions

Authored by Peiming on Mar 28 2023, 12:54 PM.

Details

Reviewers
aartbik
nicolasvasilache
bixia
wrengr
Commits
rG33267f4007c7: [mlir][sparse] convert a sparse tensor slice to sparse tensor correctly.

Diff Detail

Event Timeline

Peiming created this revision.Mar 28 2023, 12:54 PM
Herald added a reviewer: aartbik. · View Herald TranscriptMar 28 2023, 12:54 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: hanchung, jsetoain, Moerafaat and 23 others. · View Herald Transcript
Peiming requested review of this revision.Mar 28 2023, 12:54 PM
Herald added a reviewer: nicolasvasilache. · View Herald TranscriptMar 28 2023, 12:54 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
Peiming updated this revision to Diff 509106.Mar 28 2023, 12:56 PM

minor fixes.

aartbik added inline comments.Mar 28 2023, 12:59 PM
mlir/lib/Dialect/SparseTensor/Transforms/SparseTensorCodegen.cpp
1064

space after closing )

1065

add comment on slice properties (of source and dest)

1066–1068

Cannot

wrengr added inline comments.Mar 28 2023, 1:01 PM
mlir/lib/Dialect/SparseTensor/Transforms/SparseTensorCodegen.cpp
1064

You should leave the space there

1066–1068

Does ConvertOp::verify actually guarantee this condition? If not, then this should be a failure or emitError rather than an assert

Peiming updated this revision to Diff 509119.Mar 28 2023, 1:41 PM
Peiming marked 5 inline comments as done.

address comments.

Peiming added reviewers: bixia, wrengr.Mar 28 2023, 1:41 PM
aartbik accepted this revision.Mar 28 2023, 1:48 PM
This revision is now accepted and ready to land.Mar 28 2023, 1:48 PM
This revision was landed with ongoing or failed builds.Mar 28 2023, 2:39 PM
Closed by commit rG33267f4007c7: [mlir][sparse] convert a sparse tensor slice to sparse tensor correctly. (authored by Peiming). · Explain Why
This revision was automatically updated to reflect the committed changes.
Peiming added a commit: rG33267f4007c7: [mlir][sparse] convert a sparse tensor slice to sparse tensor correctly..
Harbormaster completed remote builds in B222333: Diff 509119.Mar 28 2023, 11:59 PM

Revision Contents
Changeset List

PathSize
mlir/
lib/
Dialect/
SparseTensor/
IR/
5 lines
Transforms/
7 lines
2 lines
test/
Dialect/
SparseTensor/
26 lines
13 lines

Diff 509145

View Options

mlir/lib/Dialect/SparseTensor/IR/SparseTensorDialect.cpp

Loading...
View Options

mlir/lib/Dialect/SparseTensor/Transforms/SparseTensorCodegen.cpp

Loading...
View Options

mlir/lib/Dialect/SparseTensor/Transforms/SparseTensorRewriting.cpp

Loading...
View Options

mlir/test/Dialect/SparseTensor/convert_sparse2sparse.mlir

Loading...
View Options

mlir/test/Dialect/SparseTensor/invalid.mlir

Loading...