This is an archive of the discontinued LLVM Phabricator instance.

Differential D146843

[mlir] Add missing cast functions to mlir namespace
ClosedPublic

Authored by rkayaith on Mar 24 2023, 1:14 PM.

Details

Reviewers
ftynse
dcaballe
rriddle
Commits
rG923230d45eb5: [mlir] Add missing cast functions to mlir namespace

Diff Detail

Event Timeline

rkayaith created this revision.Mar 24 2023, 1:14 PM
Herald added a reviewer: ftynse. · View Herald TranscriptMar 24 2023, 1:14 PM
Herald added a reviewer: dcaballe. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: Moerafaat, zero9178, bzcheeseman and 22 others. · View Herald Transcript
Harbormaster completed remote builds in B221672: Diff 508204.Mar 24 2023, 1:45 PM
rkayaith published this revision for review.Mar 24 2023, 3:00 PM
rkayaith added a reviewer: rriddle.
Herald added a project: Restricted Project. · View Herald TranscriptMar 24 2023, 3:00 PM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
rriddle accepted this revision.Mar 25 2023, 11:05 AM
This revision is now accepted and ready to land.Mar 25 2023, 11:05 AM
Closed by commit rG923230d45eb5: [mlir] Add missing cast functions to mlir namespace (authored by rkayaith). · Explain WhyMar 27 2023, 11:13 AM
This revision was automatically updated to reflect the committed changes.
rkayaith added a commit: rG923230d45eb5: [mlir] Add missing cast functions to mlir namespace.

Revision Contents

PathSize
mlir/
include/
mlir/
Support/
2 lines
unittests/
IR/
7 lines

Diff 508738

mlir/include/mlir/Support/LLVM.h

Show First 20 Lines • Show All 90 Lines • ▼ Show 20 Lines
class raw_ostream; class raw_ostream;
class SMLoc; class SMLoc;
class SMRange; class SMRange;
} // namespace llvm } // namespace llvm
namespace mlir { namespace mlir {
// Casting operators. // Casting operators.
using llvm::cast; using llvm::cast;
using llvm::cast_if_present;
using llvm::cast_or_null; using llvm::cast_or_null;
using llvm::dyn_cast; using llvm::dyn_cast;
using llvm::dyn_cast_if_present; using llvm::dyn_cast_if_present;
using llvm::dyn_cast_or_null; using llvm::dyn_cast_or_null;
using llvm::isa; using llvm::isa;
using llvm::isa_and_nonnull; using llvm::isa_and_nonnull;
using llvm::isa_and_present;
// String types // String types
using llvm::SmallString; using llvm::SmallString;
using llvm::StringLiteral; using llvm::StringLiteral;
using llvm::StringRef; using llvm::StringRef;
using llvm::Twine; using llvm::Twine;
// Container Related types // Container Related types
▲ Show 20 Lines • Show All 43 Lines • Show Last 20 Lines

mlir/unittests/IR/TypeTest.cpp

Show First 20 Lines • Show All 44 Lines • ▼ Show 20 LinesTEST(Type, Casting) {
Type intTy = IntegerType::get(&ctx, 8); Type intTy = IntegerType::get(&ctx, 8);
Type nullTy; Type nullTy;
MiddleType middleTy = MiddleType::get(&ctx); MiddleType middleTy = MiddleType::get(&ctx);
MiddleType leafTy = LeafType::get(&ctx); MiddleType leafTy = LeafType::get(&ctx);
Type leaf2Ty = LeafType::get(&ctx); Type leaf2Ty = LeafType::get(&ctx);
EXPECT_TRUE(isa<IntegerType>(intTy)); EXPECT_TRUE(isa<IntegerType>(intTy));
EXPECT_FALSE(isa<FunctionType>(intTy)); EXPECT_FALSE(isa<FunctionType>(intTy));
EXPECT_FALSE(llvm::isa_and_present<IntegerType>(nullTy)); EXPECT_FALSE(isa_and_present<IntegerType>(nullTy));
EXPECT_TRUE(isa<MiddleType>(middleTy)); EXPECT_TRUE(isa<MiddleType>(middleTy));
EXPECT_FALSE(isa<LeafType>(middleTy)); EXPECT_FALSE(isa<LeafType>(middleTy));
EXPECT_TRUE(isa<MiddleType>(leafTy)); EXPECT_TRUE(isa<MiddleType>(leafTy));
EXPECT_TRUE(isa<LeafType>(leaf2Ty)); EXPECT_TRUE(isa<LeafType>(leaf2Ty));
EXPECT_TRUE(isa<LeafType>(leafTy)); EXPECT_TRUE(isa<LeafType>(leafTy));
EXPECT_TRUE(static_cast<bool>(dyn_cast<IntegerType>(intTy))); EXPECT_TRUE(static_cast<bool>(dyn_cast<IntegerType>(intTy)));
EXPECT_FALSE(static_cast<bool>(dyn_cast<FunctionType>(intTy))); EXPECT_FALSE(static_cast<bool>(dyn_cast<FunctionType>(intTy)));
EXPECT_FALSE(static_cast<bool>(llvm::cast_if_present<FunctionType>(nullTy))); EXPECT_FALSE(static_cast<bool>(cast_if_present<FunctionType>(nullTy)));
EXPECT_FALSE( EXPECT_FALSE(static_cast<bool>(dyn_cast_if_present<IntegerType>(nullTy)));
static_cast<bool>(llvm::dyn_cast_if_present<IntegerType>(nullTy)));
EXPECT_EQ(8u, cast<IntegerType>(intTy).getWidth()); EXPECT_EQ(8u, cast<IntegerType>(intTy).getWidth());
} }