This is an archive of the discontinued LLVM Phabricator instance.

[X86][MemFold] Disable testcases for powerpc64-unknown-linux-gnu
AbandonedPublic

Authored by yubing on Mar 20 2023, 10:28 PM.

Diff Detail

Event Timeline

yubing created this revision.Mar 20 2023, 10:28 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 20 2023, 10:28 PM
yubing requested review of this revision.Mar 20 2023, 10:28 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 20 2023, 10:28 PM

will it work for your issue in ppc64? do we have other buildfail @abhina.sreeskantharajan

This doesn't seem like the right way to fix this. The issue is that it's complaining about --ignore-initial not being supported. I don't think checking the target is the right way to check for that. Wy do we need to skip the first 568 lines?

yubing added a comment.EditedMar 20 2023, 10:58 PM

This doesn't seem like the right way to fix this. The issue is that it's complaining about --ignore-initial not being supported. I don't think checking the target is the right way to check for that. Wy do we need to skip the first 568 lines?

the first 568 bytes are:

/*===- TableGen'erated file -------------------------------------*- C++ -*-===*\
|*                                                                            *|
|* X86 fold tables                                                            *|
|*                                                                            *|
|* Automatically generated file, do not edit!                                 *|
|*                                                                            *|
\*===----------------------------------------------------------------------===*/
skan added a comment.Mar 20 2023, 11:57 PM

Agree with craig. There are also some inc files that do not have comment TableGen'erated file in LLVM. (grep -r -L "TableGen'erated" --include=\*.inc)
I think we can remove emitSourceFileHeader("X86 fold tables", OS); and --ignore-initial=0:568 to fix this issue.

Agree with craig. There are also some inc files that do not have comment TableGen'erated file in LLVM. (grep -r -L "TableGen'erated" --include=\*.inc)
I think we can remove emitSourceFileHeader("X86 fold tables", OS); and --ignore-initial=0:568 to fix this issue.

sounds reasonable

yubing abandoned this revision.Mar 21 2023, 12:39 AM