Page MenuHomePhabricator
Differential D146487

[flang] HLFIR to FIR lowering for complex parts
ClosedPublic
Actions

Authored by elmcdonough on Mar 20 2023, 6:05 PM.

Details

Reviewers
jeanPerier
nicolasvasilache
clementval
Commits
rGe89e24446192: [flang] HLFIR to FIR lowering for complex parts
Summary

This revision implements HLFIR to FIR lowering for complex parts.

Diff Detail

Event Timeline

elmcdonough created this revision.Mar 20 2023, 6:05 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 20 2023, 6:05 PM
Herald added subscribers: sunshaoce, mehdi_amini, jdoerfert. · View Herald Transcript
elmcdonough requested review of this revision.Mar 20 2023, 6:05 PM
Herald added a reviewer: nicolasvasilache. · View Herald TranscriptMar 20 2023, 6:05 PM
Harbormaster completed remote builds in B220599: Diff 506809.Mar 20 2023, 6:46 PM
luporl added a subscriber: luporl.Mar 21 2023, 4:41 AM

Shouldn't the title of this patch be "HLFIR to FIR ..."?

elmcdonough retitled this revision from [flang] FIR to HLFIR lowering for complex parts to [flang] HLFIR to FIR lowering for complex parts.Mar 21 2023, 7:35 AM
In D146487#4209196, @luporl wrote:

Shouldn't the title of this patch be "HLFIR to FIR ..."?

Yeah, sorry for that oversight.

elmcdonough added a reviewer: clementval.Mar 22 2023, 10:38 AM
jeanPerier added a comment.Mar 23 2023, 9:55 AM

Thanks, this looks great to me.

flang/lib/Optimizer/Dialect/FIROps.cpp
2331

Interesting, I was curious why this came out in this patch and not with the current lowering, but it turns out you are also fixing a bug with the current lowering, thanks!

However, did you check if fir.rebox codegen works properly with this case?
I think it would be great to add a fir.rebox codegen test in https://github.com/llvm/llvm-project/blob/main/flang/test/Fir/rebox.fir to ensure the op verifier can be relaxed without further changes.

elmcdonough updated this revision to Diff 508856.Mar 27 2023, 5:40 PM

Added reboxing tests

Harbormaster completed remote builds in B222142: Diff 508856.Mar 27 2023, 6:34 PM
elmcdonough added a comment.Apr 3 2023, 10:24 AM

Pinging this

jeanPerier added a comment.Apr 4 2023, 2:20 AM

Thanks a lot, looks great!

jeanPerier accepted this revision.Apr 4 2023, 2:20 AM
This revision is now accepted and ready to land.Apr 4 2023, 2:20 AM
Closed by commit rGe89e24446192: [flang] HLFIR to FIR lowering for complex parts (authored by elmcdonough). · Explain WhyApr 4 2023, 12:33 PM
This revision was automatically updated to reflect the committed changes.
elmcdonough added a commit: rGe89e24446192: [flang] HLFIR to FIR lowering for complex parts.

Revision Contents
Changeset List

PathSize
flang/
lib/
Optimizer/
Dialect/
2 lines
HLFIR/
Transforms/
46 lines
test/
Fir/
72 lines
HLFIR/
83 lines

Diff 510895

View Options

flang/lib/Optimizer/Dialect/FIROps.cpp

Loading...
View Options

flang/lib/Optimizer/HLFIR/Transforms/ConvertToFIR.cpp

Loading...
View Options

flang/test/Fir/rebox.fir

Loading...
View Options

flang/test/HLFIR/designate-codegen-complex-part.fir

Loading...