Page MenuHomePhabricator

[ADT] Work around `enumerate` compilation error with modules enabled
ClosedPublic

Authored by kuhar on Mar 17 2023, 4:56 PM.

Details

Summary

This manifests on Apple clang 14 with -DLLVM_ENABLE_MODULES=1 and
-DLLVM_ENABLE_ASSERTIONS=1 and seems like a host compiler bug.

Sample compilation failure:
https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/52513/consoleFull#-458239162a1ca8a51-895e-46c6-af87-ce24fa4cd561.

Diff Detail

Unit TestsFailed

TimeTest
60,720 msx64 debian > Clang.Analysis::a_flaky_crash.cpp
Script: -- : 'RUN: at line 22'; /var/lib/buildkite-agent/builds/llvm-project/build/bin/clang -cc1 -internal-isystem /var/lib/buildkite-agent/builds/llvm-project/build/lib/clang/17/include -nostdsysteminc -analyze -analyzer-constraints=range -setup-static-analyzer -analyzer-checker=core -verify /var/lib/buildkite-agent/builds/llvm-project/clang/test/Analysis/a_flaky_crash.cpp
60,830 msx64 debian > Clang.Driver::arm-cortex-cpus-1.c
Script: -- : 'RUN: at line 7'; /var/lib/buildkite-agent/builds/llvm-project/build/bin/clang -target arm -mcpu=generic -### -c /var/lib/buildkite-agent/builds/llvm-project/clang/test/Driver/arm-cortex-cpus-1.c 2>&1 | /var/lib/buildkite-agent/builds/llvm-project/build/bin/FileCheck -check-prefix=CHECK-GENERIC /var/lib/buildkite-agent/builds/llvm-project/clang/test/Driver/arm-cortex-cpus-1.c
60,980 msx64 debian > Clang.Driver::arm-cortex-cpus-2.c
Script: -- : 'RUN: at line 8'; /var/lib/buildkite-agent/builds/llvm-project/build/bin/clang -target armv8a-linux-eabi -mcpu=cortex-a53+fp16 -### -c /var/lib/buildkite-agent/builds/llvm-project/clang/test/Driver/arm-cortex-cpus-2.c 2>&1 | /var/lib/buildkite-agent/builds/llvm-project/build/bin/FileCheck --check-prefix CHECK-CORTEX-A53-FP16 /var/lib/buildkite-agent/builds/llvm-project/clang/test/Driver/arm-cortex-cpus-2.c
60,910 msx64 debian > Clang.Driver::fsanitize.c
Script: -- : 'RUN: at line 1'; /var/lib/buildkite-agent/builds/llvm-project/build/bin/clang --target=x86_64-linux-gnu -fsanitize=undefined -fsanitize-trap=undefined /var/lib/buildkite-agent/builds/llvm-project/clang/test/Driver/fsanitize.c -### 2>&1 | /var/lib/buildkite-agent/builds/llvm-project/build/bin/FileCheck /var/lib/buildkite-agent/builds/llvm-project/clang/test/Driver/fsanitize.c --check-prefix=CHECK-UNDEFINED-TRAP
61,210 msx64 debian > Clang.OpenMP::target_defaultmap_codegen_01.cpp
Script: -- : 'RUN: at line 8'; /var/lib/buildkite-agent/builds/llvm-project/build/bin/clang -cc1 -internal-isystem /var/lib/buildkite-agent/builds/llvm-project/build/lib/clang/17/include -nostdsysteminc -no-enable-noundef-analysis -DCK1 -verify -fopenmp -fopenmp-version=50 -fopenmp-targets=powerpc64le-ibm-linux-gnu -x c++ -triple powerpc64le-unknown-unknown -emit-llvm /var/lib/buildkite-agent/builds/llvm-project/clang/test/OpenMP/target_defaultmap_codegen_01.cpp -o - | /var/lib/buildkite-agent/builds/llvm-project/build/bin/FileCheck --allow-unused-prefixes -allow-deprecated-dag-overlap /var/lib/buildkite-agent/builds/llvm-project/clang/test/OpenMP/target_defaultmap_codegen_01.cpp --check-prefix CK1
View Full Test Results (8 Failed)

Event Timeline

kuhar created this revision.Mar 17 2023, 4:56 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 17 2023, 4:56 PM
Herald added a subscriber: hanchung. · View Herald Transcript
kuhar requested review of this revision.Mar 17 2023, 4:56 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 17 2023, 4:56 PM
kuhar updated this revision to Diff 506333.Mar 18 2023, 2:43 PM

Do not calculate sizes in non-debug builds

Oh wait, I didn't realize you haven't landed it yet :-)

aprantl accepted this revision.Mar 20 2023, 11:20 AM
This revision is now accepted and ready to land.Mar 20 2023, 11:20 AM
This revision was landed with ongoing or failed builds.Mar 20 2023, 11:35 AM
This revision was automatically updated to reflect the committed changes.

Thanks! It works.